You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/08/25 01:41:53 UTC
[native-toolchain-CR] IMPALA-10089 Fix large code model issue of llvm on aarch64
zhaorenhai@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16356
Change subject: IMPALA-10089 Fix large code model issue of llvm on aarch64
......................................................................
IMPALA-10089 Fix large code model issue of llvm on aarch64
This issue referenced the following llvm issue:
https://reviews.llvm.org/D27629
If not fix, when loading test data of impala, the process will core dump.
Change-Id: I3bcca57fa97e2125334828d409c4c88040bd1312
---
M buildall.sh
A source/llvm/llvm-5.0.1-patches/0003-PATCH-Fix-for-large-code-model-on-aarch64.patch
2 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/56/16356/1
--
To view, visit http://gerrit.cloudera.org:8080/16356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bcca57fa97e2125334828d409c4c88040bd1312
Gerrit-Change-Number: 16356
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
[native-toolchain-CR] IMPALA-10089 Fix large code model issue of llvm on aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16356 )
Change subject: IMPALA-10089 Fix large code model issue of llvm on aarch64
......................................................................
Patch Set 1: Code-Review+2
Will do a test build along with the other patch.
--
To view, visit http://gerrit.cloudera.org:8080/16356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bcca57fa97e2125334828d409c4c88040bd1312
Gerrit-Change-Number: 16356
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 15:57:45 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10089 Fix large code model issue of llvm on aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16356 )
Change subject: IMPALA-10089 Fix large code model issue of llvm on aarch64
......................................................................
IMPALA-10089 Fix large code model issue of llvm on aarch64
This issue referenced the following llvm issue:
https://reviews.llvm.org/D27629
If not fix, when loading test data of impala, the process will core dump.
Change-Id: I3bcca57fa97e2125334828d409c4c88040bd1312
Reviewed-on: http://gerrit.cloudera.org:8080/16356
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M buildall.sh
A source/llvm/llvm-5.0.1-patches/0003-PATCH-Fix-for-large-code-model-on-aarch64.patch
2 files changed, 14 insertions(+), 2 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3bcca57fa97e2125334828d409c4c88040bd1312
Gerrit-Change-Number: 16356
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-10089 Fix large code model issue of llvm on aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16356 )
Change subject: IMPALA-10089 Fix large code model issue of llvm on aarch64
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bcca57fa97e2125334828d409c4c88040bd1312
Gerrit-Change-Number: 16356
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 19:13:12 +0000
Gerrit-HasComments: No