You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Bryan Ellis <er...@apache.org> on 2019/11/28 17:25:17 UTC

[VOTE] Cordova-iOS 5.1.1 Release

Please review and vote on this iOS Release v5.1.1
by replying to this email (and keep discussion on the DISCUSS thread)

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.1

The package was published from its corresponding git tag:
    cordova-ios: 5.1.1 (86a87fed74)

Note that you can test it out via:

    cordova platform add https://github.com/apache/cordova-ios#5.1.1

Upon a successful vote I will upload the archive to dist/, publish it to
npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* NPM Audit
* NPM Tests
* Build Tests

Re: [VOTE] Cordova-iOS 5.1.1 Release

Posted by Tim Brust <ti...@sinnerschrader.com.INVALID>.
I vote +1:

- CI is green
- coho verify-archive
- I could successful add the platform with WKWebViewOnly enabled

On Thu, Nov 28, 2019 at 5:25 PM Bryan Ellis <er...@apache.org> wrote:

> Please review and vote on this iOS Release v5.1.1
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.1
>
> The package was published from its corresponding git tag:
>     cordova-ios: 5.1.1 (86a87fed74)
>
> Note that you can test it out via:
>
>     cordova platform add https://github.com/apache/cordova-ios#5.1.1
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * NPM Audit
> * NPM Tests
> * Build Tests
>


-- 
Tim Brust, Product Engineer

tim.brust@sinnerschrader.com
T +49 40 398855 315

SinnerSchrader Deutschland GmbH | SinnerSchrader Group
Völckersstraße 38, 22765 Hamburg, Germany

Amtsgericht Hamburg HRB-Nr. 63663
Geschäftsführer: Matthias Schrader (Sprecher),
Jürgen Alker, Dr. Axel Averdung, Holger Blank,
Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson

Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag

https://www.sinnerschrader.com | NEXT AGENCY

Re: [VOTE] Cordova-iOS 5.1.1 Release

Posted by Bryan Ellis <er...@apache.org>.
The vote has now closed. The results are:


Positive Binding Votes: 5

* Bryan Ellis

* Jesse MacFadyen

* Julio Cesar Sanchez

* Tim Brust
* Ken Naito


Negative Binding Votes: 0

Positive Non-Binding Votes: 1
* Niklas Merz

The vote has passed.


Thanks everyone!


On Mon, Dec 2, 2019 at 8:55 AM Ken Naito <ke...@monaca.io> wrote:

> +1
>
> * coho verify-archive OK
> * coho verify-tags OK
> * The last commit a5a009c4c882879901d55e04b596bc57fa84a8b4 is green.
>
> Ken.
>
>
> On 2019/11/29 2:25, Bryan Ellis wrote:
> > Please review and vote on this iOS Release v5.1.1
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.1
> >
> > The package was published from its corresponding git tag:
> >      cordova-ios: 5.1.1 (86a87fed74)
> >
> > Note that you can test it out via:
> >
> >      cordova platform add https://github.com/apache/cordova-ios#5.1.1
> >
> > Upon a successful vote I will upload the archive to dist/, publish it to
> > npm, and post the blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * NPM Audit
> > * NPM Tests
> > * Build Tests
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>

Re: [VOTE] Cordova-iOS 5.1.1 Release

Posted by Ken Naito <ke...@monaca.io>.
+1

* coho verify-archive OK
* coho verify-tags OK
* The last commit a5a009c4c882879901d55e04b596bc57fa84a8b4 is green.

Ken.


On 2019/11/29 2:25, Bryan Ellis wrote:
> Please review and vote on this iOS Release v5.1.1
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.1
>
> The package was published from its corresponding git tag:
>      cordova-ios: 5.1.1 (86a87fed74)
>
> Note that you can test it out via:
>
>      cordova platform add https://github.com/apache/cordova-ios#5.1.1
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * NPM Audit
> * NPM Tests
> * Build Tests
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org