[GitHub] [pinot] abhioncbr commented on pull request #10814: float-double-comparison: updated for avoiding right cast transformation incase of float…

["abhioncbr (via GitHub)" <gi...@apache.org>]

abhioncbr commented on PR #10814:
URL: https://github.com/apache/pinot/pull/10814#issuecomment-1569422018

   > I feel this is not the right fix. The problem is that we always fill the value based on the value type of the LHS. Instead, we should use the common super type of LHS and RHS to perform the comparison. E.g. For INT - LONG comparison, we should read LONG values instead of INT regardless of which side has INT type.
   
   Thanks for the reference.
   
   I tried to debug the int-long comparison query and found that from calcite, we are getting cast of `Int` to `Bigint` even though the `Int` column is in LHS. 
   <img width="1584" alt="Screen Shot 2023-05-30 at 10 43 59 PM" src="https://github.com/apache/pinot/assets/1076944/f5376f04-d910-4258-bf69-b27444b54b94">
   
   
   This is not the case with float-double comparison. 
   I wonder if it is happening by itself from the calcite site or if we have some logic to control the behaviour of calcite? Any pointers?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org