You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Si Chen (JIRA)" <ji...@apache.org> on 2007/03/04 03:14:50 UTC
[jira] Created: (OFBIZ-774) balance inventory supports serialized
inventory
balance inventory supports serialized inventory
-----------------------------------------------
Key: OFBIZ-774
URL: https://issues.apache.org/jira/browse/OFBIZ-774
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: product
Reporter: Si Chen
Balance inventory currently does not do anything if the inventory just received is serialized.
Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato reopened OFBIZ-774:
-------------------------------------
Ray,
are you working with serialized inventory?
If not, I'm not totally sure that my commit is the cause of the issue you are reporting (even if it is possible).
In fact I didn't change the logic for non serialized items... or at least that was my intention.
It would be great if you (or someone interested) could test the same thing in one of the OFBiz revisions right before my commit.
If you will confirm that it was working before, I will focus on my changes to quickly spot and fix the bug.
Am I asking too much?
Thanks,
Jacopo
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Jacopo Cappellato
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494470 ]
Jacopo Cappellato commented on OFBIZ-774:
-----------------------------------------
Apart from the above notes, it doesn't seem to work properly.
See the order:
https://demo.hotwaxmedia.com/ordermgr/control/orderview?orderId=WSCO10240
for a product named "test" that I've created to exactly recreate your scenario (QOH=0, order for 5 units, serialized receipt of 1)
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Jacopo Cappellato
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Ray Barlow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494981 ]
Ray Barlow commented on OFBIZ-774:
----------------------------------
I have been testing and would have continued to test and narrow down but I needed some sleep! :-)
Sorry I didn't mean to suggest it was the very last commit of this issue that caused the problem more something along the way since it started, the first one being r514929. Although this jira issue is for serialized inventory enhancements some of the changes have been to the balance routine as a whole (like the entity queries for negative ATP items) so I thought this issue was the best place to start digging.
Anyway thanks for your change I will pull it down and test asap.
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Jacopo Cappellato
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato closed OFBIZ-774.
-----------------------------------
Resolution: Fixed
Everything should be fixed in rev. 536505
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Jacopo Cappellato
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494461 ]
Jacopo Cappellato commented on OFBIZ-774:
-----------------------------------------
Si,
I'm reviewing the code because I've seen some strange things happening with serialized inventory...
I've still not finished my work on this, but I indeed see some problems in the way serialized inventory are handled in the balanceInventoryItem service (rev. 514929):
1) at line 674: the total qoh and atp of an existing InventoryItem are updated directly, we should create an InventoryItemDetail record instead
2) (this is a big issue) at lines 669-673: the qoh is increased by one... I don't think it is correct, we should just increase the atp quantity
I'll add more comments on this soon.
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Si Chen
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494354 ]
Si Chen commented on OFBIZ-774:
-------------------------------
I think we've already fixed this, so unless you see any problems we can go ahead and close it.
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Si Chen
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494351 ]
Jacopo Cappellato commented on OFBIZ-774:
-----------------------------------------
Si,
in your example at the end of the description for this issue you say:
"[...] if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5) [...]"
I think that the correct initial values should be:
ATP = -5
QOH = 0
right?
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Si Chen
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Ray Barlow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494925 ]
Ray Barlow commented on OFBIZ-774:
----------------------------------
I'm not sure if these changes are the cause but it does seem likely. The problem is the back order quantity is no longer getting updated properly under some conditions.
A simple test is to order more than you have in stock of an item thus placing it on backorder. I did this on order:
https://demo.hotwaxmedia.com/ordermgr/control/orderview?orderId=WSCO10250
initial order qty was 15 with ATP and QOH 10/10 so 5 on back order which was shown correctly.
A few simple changes to the inventory item and we get into trouble:
https://demo.hotwaxmedia.com/facility/control/EditInventoryItem?inventoryItemId=9012
The first variance change of "Found 2" worked ok and the order was updated to 3 on backorder, but the second change of "Found 5" left the order item on back order 3. Has there been a little to much optimisation on filtering out candidates for update?
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Jacopo Cappellato
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494519 ]
Si Chen commented on OFBIZ-774:
-------------------------------
Great. I think this should be committed back to the 4.0 release branch.
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Jacopo Cappellato
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato closed OFBIZ-774.
-----------------------------------
Resolution: Fixed
Ray,
I did more tests and research and now I can confirm you that the issue you are reporting was already there before my last change.
In fact, the balance service selects only the items with ATP < 0; for this reason, as soon as you have manually changed the ATP to be greater than zero (during the second variance) the service was no more considering the current item.
However rev. 537119 will fix the issue: please help with tests!!!
Jacopo
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Jacopo Cappellato
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494986 ]
Jacopo Cappellato commented on OFBIZ-774:
-----------------------------------------
Hi Ray,
feedback like yours is really greatly appreciated! I didn't mean to look defensive on my work, sorry for giving you this impression.
I look forward at getting your feedback on my last commit.
Jacopo
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Jacopo Cappellato
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Si Chen reassigned OFBIZ-774:
-----------------------------
Assignee: Si Chen
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Si Chen
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494455 ]
Jacopo Cappellato commented on OFBIZ-774:
-----------------------------------------
Yes, I see it now: rev. 514929 right?
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Si Chen
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-774) balance inventory supports serialized
inventory
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato reassigned OFBIZ-774:
---------------------------------------
Assignee: Jacopo Cappellato (was: Si Chen)
> balance inventory supports serialized inventory
> -----------------------------------------------
>
> Key: OFBIZ-774
> URL: https://issues.apache.org/jira/browse/OFBIZ-774
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Si Chen
> Assigned To: Jacopo Cappellato
>
> Balance inventory currently does not do anything if the inventory just received is serialized.
> Instead, what should happen is that if a unit of serialized inventory is received and there are non-serialized items with ATP < 0, then it should change the serialized item to Promised and use it to offset the first unit (1.0) of the non-serialized inventory item.
> For example, if we had 5 units on back order (created as a non-serialized inventory item with ATP = -5 and QOH = -5), and 1 unit of serialized inventory comes in, then we should change ATP and QOH of non-serialized item to -4 and the status of serailized inventory item to Promised, and reserve this serialized item against the first order item reserved against the non-serialized inventory item with a quantity of 1.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.