You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/26 14:09:02 UTC
[GitHub] [airflow] potiuk opened a new pull request, #25310: Adds new warning to provider verification
potiuk opened a new pull request, #25310:
URL: https://github.com/apache/airflow/pull/25310
There is a new warning generated when you import snowflake. This is
something we cannot do much about (and it is rather harmless
because it only impacts pyarrow functionality of snowflake
connector).
Adding it will silence provider check in main builds.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #25310: Adds new warning to provider verification
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #25310:
URL: https://github.com/apache/airflow/pull/25310#discussion_r930111516
##########
scripts/in_container/verify_providers.py:
##########
@@ -141,6 +141,11 @@ class ProviderPackageDetails(NamedTuple):
"adheres to: 'pyarrow<5.1.0,>=5.0.0; extra == \"pandas\"'",
"snowflake",
),
+ (
+ "You have an incompatible version of 'pyarrow' installed (6.0.1), please install a version that "
+ "adheres to: 'pyarrow<8.1.0,>=8.0.0; extra == \"pandas\"'",
Review Comment:
I gess beam is stopping us :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #25310: Adds new warning to provider verification
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #25310:
URL: https://github.com/apache/airflow/pull/25310#discussion_r930040167
##########
scripts/in_container/verify_providers.py:
##########
@@ -141,6 +141,11 @@ class ProviderPackageDetails(NamedTuple):
"adheres to: 'pyarrow<5.1.0,>=5.0.0; extra == \"pandas\"'",
"snowflake",
),
+ (
+ "You have an incompatible version of 'pyarrow' installed (6.0.1), please install a version that "
+ "adheres to: 'pyarrow<8.1.0,>=8.0.0; extra == \"pandas\"'",
Review Comment:
Wowzers that's a narrow version of pyarrow they want to work with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #25310: Adds new warning to provider verification
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #25310:
URL: https://github.com/apache/airflow/pull/25310#discussion_r930240859
##########
scripts/in_container/verify_providers.py:
##########
@@ -141,6 +141,11 @@ class ProviderPackageDetails(NamedTuple):
"adheres to: 'pyarrow<5.1.0,>=5.0.0; extra == \"pandas\"'",
"snowflake",
),
+ (
+ "You have an incompatible version of 'pyarrow' installed (6.0.1), please install a version that "
+ "adheres to: 'pyarrow<8.1.0,>=8.0.0; extra == \"pandas\"'",
Review Comment:
Beam but not only:
* beam <8.0.0
* databricks-sql-connector < 8.0.0
* pandas-gbq <9.0.0dev <- not holiding us back
* sqlalchemy-bigquery <7.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #25310: Adds new warning to provider verification
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #25310:
URL: https://github.com/apache/airflow/pull/25310#discussion_r930241955
##########
scripts/in_container/verify_providers.py:
##########
@@ -141,6 +141,11 @@ class ProviderPackageDetails(NamedTuple):
"adheres to: 'pyarrow<5.1.0,>=5.0.0; extra == \"pandas\"'",
"snowflake",
),
+ (
+ "You have an incompatible version of 'pyarrow' installed (6.0.1), please install a version that "
+ "adheres to: 'pyarrow<8.1.0,>=8.0.0; extra == \"pandas\"'",
Review Comment:
At least this is what pipdeptree shows us in our image (there might be others that do it transitively via extras and those are only possible to see by inspecting individual packages)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25310: Adds new warning to provider verification
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25310:
URL: https://github.com/apache/airflow/pull/25310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org