[GitHub] [sling-org-apache-sling-resourceresolver] cziegeler commented on a diff in pull request #85: SLING-11604: Async VanityPathInitializer should log when completed

[GitBox <gi...@apache.org>]

cziegeler commented on code in PR #85:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/85#discussion_r1011234227


##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -341,7 +342,8 @@ private void execute() {
                 // drain once more in case more events have arrived
                 drainQueue(resourceChangeQueue);
 
-                log.debug("vanity path init - end");
+                long initElapsed = System.nanoTime() - initStart;
+                log.info("vanity path initialization - end, elapsed {}ms", TimeUnit.NANOSECONDS.toMillis(initElapsed));

Review Comment:
   I think we should have some consistency in the log message format. Below when the exception is logged it is "VanityPath", here (and above) it is "vanity path"; I haven't checked the whole code - but at least here using "VanityPath" seems to be more consistent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org