[GitHub] [activemq-artemis] clebertsuconic commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

[GitBox <gi...@apache.org>]

clebertsuconic commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning
URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487300738
 
 
   @michaelandrepearce I don't think that's a good idea. static classes can be useful to avoid clutter, when the logic only makes sense in the context of that class.
   
   static classes can be in their own class file.. should is a strong word on this IMHO.
   
   
   Like the other day I moved an independent class as a static class file, as the class only made sense in the context of the test.
   
   
   Having said that though, I don'w think we should abuse static classes... I'm just saying that in some cases the class doesn't make sense as an independent class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services