You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/20 02:31:27 UTC
[GitHub] [spark] ulysses-you opened a new pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
ulysses-you opened a new pull request #34336:
URL: https://github.com/apache/spark/pull/34336
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add outer side rows in `Join.maxRows` if the join type is outer join.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Outer join should return at least num rows of it's outer side, i.e left outer join with its left side, right outer join with its right side, full outer join with its both side.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
yes, bug fix
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
add test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34336:
URL: https://github.com/apache/spark/pull/34336#discussion_r732389211
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -383,8 +383,16 @@ case class Join(
override def maxRows: Option[Long] = {
joinType match {
case Inner | Cross | FullOuter | LeftOuter | RightOuter
- if left.maxRows.isDefined && right.maxRows.isDefined =>
- val maxRows = BigInt(left.maxRows.get) * BigInt(right.maxRows.get)
+ if left.maxRows.isDefined && right.maxRows.isDefined =>
+ val leftMaxRows = BigInt(left.maxRows.get)
+ val rightMaxRows = BigInt(right.maxRows.get)
+ val maxRows = joinType match {
Review comment:
how about
```
val minRows = joinType match {
case LeftOuter => leftMaxRows
...
case FullOuter => leftMaxRows + rightMaxRows
case _ => BigInt(0)
}
(leftMaxRows * rightMaxRows).max(minRows)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947413221
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144435/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947318607
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48911/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947411457
**[Test build #144435 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144435/testReport)** for PR 34336 at commit [`0ea2984`](https://github.com/apache/spark/commit/0ea2984d9c4fe4c961112047dd66ea864c9ac274).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947322681
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48908/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947425914
thanks, merging to master/3.2!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947413221
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144435/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947458280
**[Test build #144438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144438/testReport)** for PR 34336 at commit [`77a9cb5`](https://github.com/apache/spark/commit/77a9cb5954d7c3778edeadc76a45c47f5ea1a153).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947322656
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48914/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947460411
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144438/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947300734
**[Test build #144441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144441/testReport)** for PR 34336 at commit [`cbf0f26`](https://github.com/apache/spark/commit/cbf0f26f276559e502cabc0c04649120c095936e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947344962
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48911/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947297574
**[Test build #144438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144438/testReport)** for PR 34336 at commit [`77a9cb5`](https://github.com/apache/spark/commit/77a9cb5954d7c3778edeadc76a45c47f5ea1a153).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947452091
**[Test build #144441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144441/testReport)** for PR 34336 at commit [`cbf0f26`](https://github.com/apache/spark/commit/cbf0f26f276559e502cabc0c04649120c095936e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947270291
**[Test build #144435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144435/testReport)** for PR 34336 at commit [`0ea2984`](https://github.com/apache/spark/commit/0ea2984d9c4fe4c961112047dd66ea864c9ac274).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947460411
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144438/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947333745
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48911/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34336:
URL: https://github.com/apache/spark/pull/34336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947345283
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48914/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947289316
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48908/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947451674
thank you @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947300734
**[Test build #144441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144441/testReport)** for PR 34336 at commit [`cbf0f26`](https://github.com/apache/spark/commit/cbf0f26f276559e502cabc0c04649120c095936e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947345257
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48914/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947344962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #34336:
URL: https://github.com/apache/spark/pull/34336#discussion_r732394593
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -383,8 +383,16 @@ case class Join(
override def maxRows: Option[Long] = {
joinType match {
case Inner | Cross | FullOuter | LeftOuter | RightOuter
- if left.maxRows.isDefined && right.maxRows.isDefined =>
- val maxRows = BigInt(left.maxRows.get) * BigInt(right.maxRows.get)
+ if left.maxRows.isDefined && right.maxRows.isDefined =>
+ val leftMaxRows = BigInt(left.maxRows.get)
+ val rightMaxRows = BigInt(right.maxRows.get)
+ val maxRows = joinType match {
Review comment:
I'm fine with this version which looks more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947322681
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48908/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947270291
**[Test build #144435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144435/testReport)** for PR 34336 at commit [`0ea2984`](https://github.com/apache/spark/commit/0ea2984d9c4fe4c961112047dd66ea864c9ac274).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947453919
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144441/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947453919
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144441/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947297574
**[Test build #144438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144438/testReport)** for PR 34336 at commit [`77a9cb5`](https://github.com/apache/spark/commit/77a9cb5954d7c3778edeadc76a45c47f5ea1a153).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34336: [SPARK-37064][SQL] Fix outer join return the wrong max rows if other side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34336:
URL: https://github.com/apache/spark/pull/34336#issuecomment-947309751
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48908/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org