You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mprudhom <gi...@git.apache.org> on 2015/10/27 23:28:16 UTC
[GitHub] spark pull request: Header formatting fix
GitHub user mprudhom opened a pull request:
https://github.com/apache/spark/pull/9312
Header formatting fix
The header wasn't indented properly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mprudhom/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9312
----
commit 16d856cf2e5d9847a85c6e8f4342ad412da70083
Author: Marc Prud'hommeaux <mw...@cornell.edu>
Date: 2015-10-27T22:27:52Z
Header formatting fix
The header wasn't indented properly.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Header formatting fix
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Header formatting fix
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9312#issuecomment-155617160
It's good to fix even if we have to do it 1 at a time. Merging into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Header formatting fix
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9312#issuecomment-151847282
Hm, OK. The thing is (unfortunately) a fair number of the copyright headers aren't strictly correctly formatted. Many start with javadoc-style opening for example. Functionally it makes no difference and the automatic copyright checker will deal with it all. So it doesn't really seem worth fixing this up everywhere. I can maybe see fixing this if making changes to the header of the file otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Header formatting fix
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9312#issuecomment-151664588
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org