You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/07/16 10:12:05 UTC

[PR] Refactor MCP workflow validation and artifact handling [shardingsphere]

terrymanu opened a new pull request, #39158:
URL: https://github.com/apache/shardingsphere/pull/39158

   - enforce transport security before protocol request validation
   - remove physical DDL and index artifacts from MCP workflows
   - validate workflow state with semantic rule comparisons
   - provide runtime resource hints for feature workflows
   - expand MCP unit and E2E contract coverage
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor MCP workflow validation and artifact handling [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39158:
URL: https://github.com/apache/shardingsphere/pull/39158#issuecomment-4990949523

   ### Summary
   
   **Review Result: Mergeable**
   
   Reason: The current workspace state—the public PR head `4215ba9503c9faf597d15d0b1393a414b68209a0` plus the uncommitted local fix—has passed the code-scope review. CI not reviewed by request. The local changes must be committed and pushed before the GitHub PR includes this fix.
   
   ### Evidence
   
   - Named key generators are now validated through the existing `queryTableRulesUsedKeyGenerator` boundary, confirming the target table’s actual binding.
   - Inline key generators continue to be validated by type and properties, preserving existing behavior.
   - Positive and negative regression tests cover correct and incorrect named-generator bindings.
   - No public APIs, MCP schemas, new types, or cross-module dependencies were introduced.
   - Spotless completed successfully.
   - All 582 upstream dependency tests and 130 sharding MCP module tests passed, including 20 validation-service tests.
   - Checkstyle completed successfully.
   - All 87 PR files and the two-file local fix were reviewed. Three consecutive adversarial passes found no new issues.
   
   ### Review Details
   
   - **Review Focus:** Code Correctness Review — CI not reviewed by request.
   - **Reviewed Scope:** All 87 PR files, local merge-base `6ecd9c15b0ea089c6036fa4d1776098a19b03cb1`, and the local changes to `ShardingWorkflowValidationService` and its tests. The local and GitHub file inventories matched.
   - **Not Reviewed Scope:** GitHub Actions and E2E scenarios requiring an external Proxy environment.
   - **Verification:** `spotless:apply`, `mcp/features/sharding -am test`, and `checkstyle:check` all completed with exit code 0.
   - **Release Note / User Docs:** Not required. The fix corrects existing workflow validation without changing tool interfaces or user configuration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor MCP workflow validation and artifact handling [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39158:
URL: https://github.com/apache/shardingsphere/pull/39158


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org