You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/09/05 00:59:11 UTC
[GitHub] erisu commented on a change in pull request #490: WIP: Fixes build
& run related bugs from builder refactor
erisu commented on a change in pull request #490: WIP: Fixes build & run related bugs from builder refactor
URL: https://github.com/apache/cordova-android/pull/490#discussion_r215109516
##########
File path: bin/templates/cordova/lib/builders/ProjectBuilder.js
##########
@@ -295,12 +294,18 @@ class ProjectBuilder {
}
findOutputApks (build_type, arch) {
- var self = this;
- return Object.keys(this.binDirs).reduce(function (result, builderName) {
- var binDir = self.binDirs[builderName];
- return result.concat(findOutputApksHelper(binDir, build_type, builderName === 'ant' ? null : arch));
+ return Object.keys(this.binDirs).reduce((result, builderName) => {
Review comment:
Yes, I also think this can be simplified.
Originally I was going to but decided to wait and clean up the other other areas first. Thanks for reminding me this one. I will take a look at it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org