You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/31 12:05:59 UTC
[GitHub] [spark] bjornjorgensen opened a new pull request, #39327: [SPARK-41801][PS] Remove `*args: Any, **kwargs: Any` for `def transpose`
bjornjorgensen opened a new pull request, #39327:
URL: https://github.com/apache/spark/pull/39327
### What changes were proposed in this pull request?
Change `def transpose(self, *args: Any, **kwargs: Any) -> "Series":`
to
`def transpose(self) -> "Series":`
### Why are the changes needed?
`def transpose(self, *args: Any, **kwargs: Any) -> "Series":`
This function only `return self.copy()`
[Sonar](https://sonarcloud.io/project/issues?languages=py&resolved=false&severities=BLOCKER&id=spark-python&open=AYQdnWmTRrJbVxW9ZCsf)
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39327: [SPARK-41801][CORE][PYTHON][PS] Remove `*args: Any, **kwargs: Any` for `def transpose`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #39327:
URL: https://github.com/apache/spark/pull/39327#discussion_r1059725953
##########
python/pyspark/pandas/series.py:
##########
@@ -3822,7 +3822,7 @@ def aggregate(self, func: Union[str, List[str]]) -> Union[Scalar, "Series"]:
agg = aggregate
- def transpose(self, *args: Any, **kwargs: Any) -> "Series":
+ def transpose(self) -> "Series":
Review Comment:
Hm, I think we should better keep it for now for pandas compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #39327: [SPARK-41801][CORE][PYTHON][PS] Remove `*args: Any, **kwargs: Any` for `def transpose`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #39327: [SPARK-41801][CORE][PYTHON][PS] Remove `*args: Any, **kwargs: Any` for `def transpose`
URL: https://github.com/apache/spark/pull/39327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39327: [SPARK-41801][CORE][PYTHON][PS] Remove `*args: Any, **kwargs: Any` for `def transpose`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #39327:
URL: https://github.com/apache/spark/pull/39327#discussion_r1059726025
##########
python/pyspark/pandas/series.py:
##########
@@ -3822,7 +3822,7 @@ def aggregate(self, func: Union[str, List[str]]) -> Union[Scalar, "Series"]:
agg = aggregate
- def transpose(self, *args: Any, **kwargs: Any) -> "Series":
+ def transpose(self) -> "Series":
Review Comment:
Or would be nicer if we implement these parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #39327: [SPARK-41801][CORE][PYTHON][PS] Remove `*args: Any, **kwargs: Any` for `def transpose`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #39327:
URL: https://github.com/apache/spark/pull/39327#issuecomment-1369184702
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #39327: [SPARK-41801][CORE][PYTHON][PS] Remove `*args: Any, **kwargs: Any` for `def transpose`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39327:
URL: https://github.com/apache/spark/pull/39327#issuecomment-1506130307
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org