[GitHub] RPDiep opened a new pull request #2988: Security Group: add secondary ips to the correct ipset based on ip family

[GitBox <gi...@apache.org>]

RPDiep opened a new pull request #2988: Security Group: add secondary ips to the correct ipset based on ip family
URL: https://github.com/apache/cloudstack/pull/2988
 
 
   ## Description
   <!--- Describe your changes in detail -->
   Currently secondary ipv6 addresses are added to the ipv4 ipset in `security_group.py`.
   This doesn't work, so this patch adds a function to split a set of ips in ipv4 and ipv6 addresses.
   Both the `default_network_rules` and `` functions now utilise this function and add the ips to the appropriate ipsets.
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   Not tested live yet. The function has been tested in idle.
   Will ask my colleague @GabrielBrascher  to test this.
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services