You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2023/05/24 16:30:30 UTC

[GitHub] [flink-connector-jdbc] snuyanzin commented on pull request #3: [FLINK-15462][connectors] Add Trino dialect

snuyanzin commented on PR #3:
URL: https://github.com/apache/flink-connector-jdbc/pull/3#issuecomment-1561540897

   thanks @eskabetxe 
   in general it looks ok from my side
   
   i have a question about `FLOAT`/`REAL` in comments
   and some comments about tests
   
   also can you please update doc at https://github.com/apache/flink-connector-jdbc/blob/main/docs/content/docs/connectors/table/jdbc.md
   and probably chinese version as well?
   + need to resolve conflicts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org