You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/13 11:07:45 UTC
[GitHub] [maven-enforcer] michael-o commented on a diff in pull request #187: [MENFORCER-427] New rule to ban dynamic versions
michael-o commented on code in PR #187:
URL: https://github.com/apache/maven-enforcer/pull/187#discussion_r994491972
##########
enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/BanDynamicVersions.java:
##########
@@ -0,0 +1,375 @@
+package org.apache.maven.plugins.enforcer;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.text.ChoiceFormat;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.List;
+import java.util.function.Predicate;
+import java.util.stream.Collectors;
+
+import org.apache.maven.RepositoryUtils;
+import org.apache.maven.artifact.versioning.InvalidVersionSpecificationException;
+import org.apache.maven.enforcer.rule.api.EnforcerRuleException;
+import org.apache.maven.enforcer.rule.api.EnforcerRuleHelper;
+import org.apache.maven.plugin.logging.Log;
+import org.apache.maven.plugins.enforcer.utils.ArtifactMatcher;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import org.codehaus.plexus.component.repository.exception.ComponentLookupException;
+import org.eclipse.aether.DefaultRepositorySystemSession;
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.collection.CollectRequest;
+import org.eclipse.aether.collection.CollectResult;
+import org.eclipse.aether.collection.DependencyCollectionException;
+import org.eclipse.aether.collection.DependencySelector;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+import org.eclipse.aether.graph.DependencyVisitor;
+import org.eclipse.aether.repository.RemoteRepository;
+import org.eclipse.aether.util.graph.selector.AndDependencySelector;
+import org.eclipse.aether.util.graph.selector.OptionalDependencySelector;
+import org.eclipse.aether.util.graph.selector.ScopeDependencySelector;
+import org.eclipse.aether.util.graph.visitor.TreeDependencyVisitor;
+import org.eclipse.aether.version.VersionConstraint;
+
+/**
+ * This rule bans dependencies having a version which requires resolution (i.e. dynamic versions which might change with
+ * each build). Dynamic versions are either
+ * <ul>
+ * <li>version ranges,</li>
+ * <li>the special placeholders {@code LATEST} or {@code RELEASE} or</li>
+ * <li>versions ending with {@code -SNAPSHOT}.
+ * </ul>
+ *
+ * @since 3.2.0
+ */
+public class BanDynamicVersions
+ extends AbstractNonCacheableEnforcerRule
+{
+
+ private static final String RELEASE = "RELEASE";
+
+ private static final String LATEST = "LATEST";
+
+ private static final String SNAPSHOT_SUFFIX = "-SNAPSHOT";
+
+ /**
+ * {@code true} if versions ending with {@code -SNAPSHOT} should be allowed
+ */
+ private boolean allowSnapshots;
+
+ /**
+ * {@code true} if versions using {@code LATEST} should be allowed
+ */
+ private boolean allowLatest;
+
+ /**
+ * {@code true} if versions using {@code RELEASE} should be allowed
+ */
+ private boolean allowRelease;
+
+ /**
+ * {@code true} if version ranges should be allowed
+ */
+ private boolean allowRanges;
+
+ /**
+ * {@code true} if also optional dependencies should be checked
+ */
+ private boolean checkOptionals;
+
+ /**
+ * the scopes of dependencies which should be excluded from this rule
+ */
+ private String[] excludedScopes;
+
+ /**
+ * Specify the ignored dependencies. This can be a list of artifacts in the format
+ * <code>groupId[:artifactId][:version]</code>. Any of the sections can be a wildcard by using '*' (ie group:*:1.0)
+ * <br>
+ * The rule will fail if any dependency matches any exclude, unless it also matches an include rule.
+ *
+ * @see {@link #setIgnores(List)}
+ */
+ private List<String> ignores = null;
+
+ public void setIgnores( List<String> ignores )
+ {
+ this.ignores = ignores;
+ }
+
+ public void setAllowSnapshots( boolean allowSnapshots )
+ {
+ this.allowSnapshots = allowSnapshots;
+ }
+
+ public void setAllowLatest( boolean allowLatest )
+ {
+ this.allowLatest = allowLatest;
+ }
+
+ public void setAllowRelease( boolean allowRelease )
+ {
+ this.allowRelease = allowRelease;
+ }
+
+ public void setAllowRanges( boolean allowRanges )
+ {
+ this.allowRanges = allowRanges;
+ }
+
+ public void setCheckOptionals( boolean checkOptionals )
+ {
+ this.checkOptionals = checkOptionals;
+ }
+
+ public void setExcludedScopes( String[] excludedScopes )
+ {
+ this.excludedScopes = excludedScopes;
+ }
+
+ private final class BannedDynamicVersionCollector
+ implements DependencyVisitor
+ {
+
+ private final Log log;
+
+ private final Deque<DependencyNode> nodeStack; // all intermediate nodes (without the root node)
+
+ private boolean isRoot = true;
+
+ private int numViolations;
+
+ private final Predicate<DependencyNode> predicate;
+
+ public int getNumViolations()
+ {
+ return numViolations;
+ }
+
+ BannedDynamicVersionCollector( Log log, Predicate<DependencyNode> predicate )
+ {
+ this.log = log;
+ nodeStack = new ArrayDeque<>();
+ this.predicate = predicate;
+ this.isRoot = true;
+ numViolations = 0;
+ }
+
+ private boolean isBannedDynamicVersion( VersionConstraint versionConstraint )
+ {
+ if ( versionConstraint.getVersion() != null )
+ {
+ if ( versionConstraint.getVersion().toString().equals( LATEST ) )
+ {
+ return !allowLatest;
+ }
+ else if ( versionConstraint.getVersion().toString().equals( RELEASE ) )
+ {
+ return !allowRelease;
+ }
+ else if ( versionConstraint.getVersion().toString().endsWith( SNAPSHOT_SUFFIX ) )
+ {
+ return !allowSnapshots;
+ }
Review Comment:
Isn't there a better way tthan relying on `#toString()`?
##########
enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/BanDynamicVersions.java:
##########
@@ -0,0 +1,375 @@
+package org.apache.maven.plugins.enforcer;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.text.ChoiceFormat;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.List;
+import java.util.function.Predicate;
+import java.util.stream.Collectors;
+
+import org.apache.maven.RepositoryUtils;
+import org.apache.maven.artifact.versioning.InvalidVersionSpecificationException;
+import org.apache.maven.enforcer.rule.api.EnforcerRuleException;
+import org.apache.maven.enforcer.rule.api.EnforcerRuleHelper;
+import org.apache.maven.plugin.logging.Log;
+import org.apache.maven.plugins.enforcer.utils.ArtifactMatcher;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import org.codehaus.plexus.component.repository.exception.ComponentLookupException;
+import org.eclipse.aether.DefaultRepositorySystemSession;
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.collection.CollectRequest;
+import org.eclipse.aether.collection.CollectResult;
+import org.eclipse.aether.collection.DependencyCollectionException;
+import org.eclipse.aether.collection.DependencySelector;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+import org.eclipse.aether.graph.DependencyVisitor;
+import org.eclipse.aether.repository.RemoteRepository;
+import org.eclipse.aether.util.graph.selector.AndDependencySelector;
+import org.eclipse.aether.util.graph.selector.OptionalDependencySelector;
+import org.eclipse.aether.util.graph.selector.ScopeDependencySelector;
+import org.eclipse.aether.util.graph.visitor.TreeDependencyVisitor;
+import org.eclipse.aether.version.VersionConstraint;
+
+/**
+ * This rule bans dependencies having a version which requires resolution (i.e. dynamic versions which might change with
+ * each build). Dynamic versions are either
+ * <ul>
+ * <li>version ranges,</li>
+ * <li>the special placeholders {@code LATEST} or {@code RELEASE} or</li>
+ * <li>versions ending with {@code -SNAPSHOT}.
+ * </ul>
+ *
+ * @since 3.2.0
+ */
+public class BanDynamicVersions
+ extends AbstractNonCacheableEnforcerRule
+{
+
+ private static final String RELEASE = "RELEASE";
+
+ private static final String LATEST = "LATEST";
+
+ private static final String SNAPSHOT_SUFFIX = "-SNAPSHOT";
+
+ /**
+ * {@code true} if versions ending with {@code -SNAPSHOT} should be allowed
+ */
+ private boolean allowSnapshots;
+
+ /**
+ * {@code true} if versions using {@code LATEST} should be allowed
+ */
+ private boolean allowLatest;
+
+ /**
+ * {@code true} if versions using {@code RELEASE} should be allowed
+ */
+ private boolean allowRelease;
+
+ /**
+ * {@code true} if version ranges should be allowed
+ */
+ private boolean allowRanges;
+
+ /**
+ * {@code true} if also optional dependencies should be checked
+ */
+ private boolean checkOptionals;
+
+ /**
+ * the scopes of dependencies which should be excluded from this rule
+ */
+ private String[] excludedScopes;
+
+ /**
+ * Specify the ignored dependencies. This can be a list of artifacts in the format
+ * <code>groupId[:artifactId][:version]</code>. Any of the sections can be a wildcard by using '*' (ie group:*:1.0)
+ * <br>
+ * The rule will fail if any dependency matches any exclude, unless it also matches an include rule.
+ *
+ * @see {@link #setIgnores(List)}
+ */
+ private List<String> ignores = null;
+
+ public void setIgnores( List<String> ignores )
+ {
+ this.ignores = ignores;
+ }
+
+ public void setAllowSnapshots( boolean allowSnapshots )
+ {
+ this.allowSnapshots = allowSnapshots;
+ }
+
+ public void setAllowLatest( boolean allowLatest )
+ {
+ this.allowLatest = allowLatest;
+ }
+
+ public void setAllowRelease( boolean allowRelease )
+ {
+ this.allowRelease = allowRelease;
+ }
+
+ public void setAllowRanges( boolean allowRanges )
+ {
+ this.allowRanges = allowRanges;
+ }
+
+ public void setCheckOptionals( boolean checkOptionals )
+ {
+ this.checkOptionals = checkOptionals;
+ }
+
+ public void setExcludedScopes( String[] excludedScopes )
+ {
+ this.excludedScopes = excludedScopes;
+ }
+
+ private final class BannedDynamicVersionCollector
+ implements DependencyVisitor
+ {
+
+ private final Log log;
+
+ private final Deque<DependencyNode> nodeStack; // all intermediate nodes (without the root node)
+
+ private boolean isRoot = true;
+
+ private int numViolations;
+
+ private final Predicate<DependencyNode> predicate;
+
+ public int getNumViolations()
+ {
+ return numViolations;
+ }
+
+ BannedDynamicVersionCollector( Log log, Predicate<DependencyNode> predicate )
+ {
+ this.log = log;
+ nodeStack = new ArrayDeque<>();
+ this.predicate = predicate;
+ this.isRoot = true;
+ numViolations = 0;
+ }
+
+ private boolean isBannedDynamicVersion( VersionConstraint versionConstraint )
+ {
+ if ( versionConstraint.getVersion() != null )
+ {
+ if ( versionConstraint.getVersion().toString().equals( LATEST ) )
+ {
+ return !allowLatest;
+ }
+ else if ( versionConstraint.getVersion().toString().equals( RELEASE ) )
+ {
+ return !allowRelease;
+ }
+ else if ( versionConstraint.getVersion().toString().endsWith( SNAPSHOT_SUFFIX ) )
+ {
+ return !allowSnapshots;
+ }
+ }
+ else if ( versionConstraint.getRange() != null )
+ {
+ return !allowRanges;
+ }
+ else
+ {
+ log.warn( "Unexpected version constraint found: " + versionConstraint );
+ }
+ return false;
+
+ }
+
+ @Override
+ public boolean visitEnter( DependencyNode node )
+ {
+ if ( isRoot )
+ {
+ isRoot = false;
+ }
+ else
+ {
+ log.debug( "Found node " + node + " with version constraint " + node.getVersionConstraint() );
+ if ( predicate.test( node ) && isBannedDynamicVersion( node.getVersionConstraint() ) )
+ {
+ MessageBuilder msgBuilder = MessageUtils.buffer();
+ log.warn( msgBuilder.a( "Dependency " )
+ .strong( node.getDependency() )
+ .mojo( dumpIntermediatePath( nodeStack ) )
+ .a( " is referenced with a banned dynamic version " + node.getVersionConstraint() )
+ .toString() );
+ numViolations++;
+ return false;
+ }
+ nodeStack.addLast( node );
+ }
+ return true;
+ }
+
+ @Override
+ public boolean visitLeave( DependencyNode node )
+ {
+ if ( !nodeStack.isEmpty() )
+ {
+ nodeStack.removeLast();
+ }
+ return true;
+ }
+ }
+
+ @SuppressWarnings( "unchecked" )
+ @Override
+ public void execute( EnforcerRuleHelper helper )
+ throws EnforcerRuleException
+ {
+ MavenProject project;
+ DefaultRepositorySystemSession newRepoSession;
+ RepositorySystem repoSystem;
+ List<RemoteRepository> remoteRepositories;
+ try
+ {
+ project = (MavenProject) helper.evaluate( "${project}" );
+ if ( project == null )
+ {
+ throw new ExpressionEvaluationException( "${project} is null" );
+ }
+ RepositorySystemSession repoSession =
+ (RepositorySystemSession) helper.evaluate( "${repositorySystemSession}" );
+ if ( repoSession == null )
+ {
+ throw new ExpressionEvaluationException( "${repositorySystemSession} is null" );
+ }
+ // get a new session to be able to tweak the dependency selector
+ newRepoSession = new DefaultRepositorySystemSession( repoSession );
+ remoteRepositories = (List<RemoteRepository>) helper.evaluate( "${project.remoteProjectRepositories}" );
+ repoSystem = helper.getComponent( RepositorySystem.class );
+ }
+ catch ( ExpressionEvaluationException eee )
+ {
+ throw new EnforcerRuleException( "Cannot resolve expression: " + eee.getCause(), eee );
Review Comment:
This duplicates the message. I think ` throw new EnforcerRuleException( "Cannot resolve expression", eee )` is enough.
##########
enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/BanDynamicVersions.java:
##########
@@ -0,0 +1,375 @@
+package org.apache.maven.plugins.enforcer;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.text.ChoiceFormat;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.List;
+import java.util.function.Predicate;
+import java.util.stream.Collectors;
+
+import org.apache.maven.RepositoryUtils;
+import org.apache.maven.artifact.versioning.InvalidVersionSpecificationException;
+import org.apache.maven.enforcer.rule.api.EnforcerRuleException;
+import org.apache.maven.enforcer.rule.api.EnforcerRuleHelper;
+import org.apache.maven.plugin.logging.Log;
+import org.apache.maven.plugins.enforcer.utils.ArtifactMatcher;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import org.codehaus.plexus.component.repository.exception.ComponentLookupException;
+import org.eclipse.aether.DefaultRepositorySystemSession;
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.collection.CollectRequest;
+import org.eclipse.aether.collection.CollectResult;
+import org.eclipse.aether.collection.DependencyCollectionException;
+import org.eclipse.aether.collection.DependencySelector;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+import org.eclipse.aether.graph.DependencyVisitor;
+import org.eclipse.aether.repository.RemoteRepository;
+import org.eclipse.aether.util.graph.selector.AndDependencySelector;
+import org.eclipse.aether.util.graph.selector.OptionalDependencySelector;
+import org.eclipse.aether.util.graph.selector.ScopeDependencySelector;
+import org.eclipse.aether.util.graph.visitor.TreeDependencyVisitor;
+import org.eclipse.aether.version.VersionConstraint;
+
+/**
+ * This rule bans dependencies having a version which requires resolution (i.e. dynamic versions which might change with
+ * each build). Dynamic versions are either
+ * <ul>
+ * <li>version ranges,</li>
+ * <li>the special placeholders {@code LATEST} or {@code RELEASE} or</li>
+ * <li>versions ending with {@code -SNAPSHOT}.
+ * </ul>
+ *
+ * @since 3.2.0
+ */
+public class BanDynamicVersions
+ extends AbstractNonCacheableEnforcerRule
+{
+
+ private static final String RELEASE = "RELEASE";
+
+ private static final String LATEST = "LATEST";
+
+ private static final String SNAPSHOT_SUFFIX = "-SNAPSHOT";
+
+ /**
+ * {@code true} if versions ending with {@code -SNAPSHOT} should be allowed
+ */
+ private boolean allowSnapshots;
+
+ /**
+ * {@code true} if versions using {@code LATEST} should be allowed
+ */
+ private boolean allowLatest;
+
+ /**
+ * {@code true} if versions using {@code RELEASE} should be allowed
+ */
+ private boolean allowRelease;
+
+ /**
+ * {@code true} if version ranges should be allowed
+ */
+ private boolean allowRanges;
+
+ /**
+ * {@code true} if also optional dependencies should be checked
+ */
+ private boolean checkOptionals;
+
+ /**
+ * the scopes of dependencies which should be excluded from this rule
+ */
+ private String[] excludedScopes;
+
+ /**
+ * Specify the ignored dependencies. This can be a list of artifacts in the format
+ * <code>groupId[:artifactId][:version]</code>. Any of the sections can be a wildcard by using '*' (ie group:*:1.0)
+ * <br>
+ * The rule will fail if any dependency matches any exclude, unless it also matches an include rule.
+ *
+ * @see {@link #setIgnores(List)}
+ */
+ private List<String> ignores = null;
+
+ public void setIgnores( List<String> ignores )
+ {
+ this.ignores = ignores;
+ }
+
+ public void setAllowSnapshots( boolean allowSnapshots )
+ {
+ this.allowSnapshots = allowSnapshots;
+ }
+
+ public void setAllowLatest( boolean allowLatest )
+ {
+ this.allowLatest = allowLatest;
+ }
+
+ public void setAllowRelease( boolean allowRelease )
+ {
+ this.allowRelease = allowRelease;
+ }
+
+ public void setAllowRanges( boolean allowRanges )
+ {
+ this.allowRanges = allowRanges;
+ }
+
+ public void setCheckOptionals( boolean checkOptionals )
+ {
+ this.checkOptionals = checkOptionals;
+ }
+
+ public void setExcludedScopes( String[] excludedScopes )
+ {
+ this.excludedScopes = excludedScopes;
+ }
+
+ private final class BannedDynamicVersionCollector
+ implements DependencyVisitor
+ {
+
+ private final Log log;
+
+ private final Deque<DependencyNode> nodeStack; // all intermediate nodes (without the root node)
+
+ private boolean isRoot = true;
+
+ private int numViolations;
+
+ private final Predicate<DependencyNode> predicate;
+
+ public int getNumViolations()
+ {
+ return numViolations;
+ }
+
+ BannedDynamicVersionCollector( Log log, Predicate<DependencyNode> predicate )
+ {
+ this.log = log;
+ nodeStack = new ArrayDeque<>();
+ this.predicate = predicate;
+ this.isRoot = true;
+ numViolations = 0;
+ }
+
+ private boolean isBannedDynamicVersion( VersionConstraint versionConstraint )
+ {
+ if ( versionConstraint.getVersion() != null )
+ {
+ if ( versionConstraint.getVersion().toString().equals( LATEST ) )
+ {
+ return !allowLatest;
+ }
+ else if ( versionConstraint.getVersion().toString().equals( RELEASE ) )
+ {
+ return !allowRelease;
+ }
+ else if ( versionConstraint.getVersion().toString().endsWith( SNAPSHOT_SUFFIX ) )
+ {
+ return !allowSnapshots;
+ }
+ }
+ else if ( versionConstraint.getRange() != null )
+ {
+ return !allowRanges;
+ }
+ else
+ {
+ log.warn( "Unexpected version constraint found: " + versionConstraint );
+ }
+ return false;
+
+ }
+
+ @Override
+ public boolean visitEnter( DependencyNode node )
+ {
+ if ( isRoot )
+ {
+ isRoot = false;
+ }
+ else
+ {
+ log.debug( "Found node " + node + " with version constraint " + node.getVersionConstraint() );
+ if ( predicate.test( node ) && isBannedDynamicVersion( node.getVersionConstraint() ) )
+ {
+ MessageBuilder msgBuilder = MessageUtils.buffer();
+ log.warn( msgBuilder.a( "Dependency " )
+ .strong( node.getDependency() )
+ .mojo( dumpIntermediatePath( nodeStack ) )
+ .a( " is referenced with a banned dynamic version " + node.getVersionConstraint() )
+ .toString() );
+ numViolations++;
+ return false;
+ }
+ nodeStack.addLast( node );
+ }
+ return true;
+ }
+
+ @Override
+ public boolean visitLeave( DependencyNode node )
+ {
+ if ( !nodeStack.isEmpty() )
+ {
+ nodeStack.removeLast();
+ }
+ return true;
+ }
+ }
+
+ @SuppressWarnings( "unchecked" )
+ @Override
+ public void execute( EnforcerRuleHelper helper )
+ throws EnforcerRuleException
+ {
+ MavenProject project;
+ DefaultRepositorySystemSession newRepoSession;
+ RepositorySystem repoSystem;
+ List<RemoteRepository> remoteRepositories;
+ try
+ {
+ project = (MavenProject) helper.evaluate( "${project}" );
+ if ( project == null )
+ {
+ throw new ExpressionEvaluationException( "${project} is null" );
+ }
+ RepositorySystemSession repoSession =
+ (RepositorySystemSession) helper.evaluate( "${repositorySystemSession}" );
+ if ( repoSession == null )
+ {
+ throw new ExpressionEvaluationException( "${repositorySystemSession} is null" );
+ }
+ // get a new session to be able to tweak the dependency selector
+ newRepoSession = new DefaultRepositorySystemSession( repoSession );
+ remoteRepositories = (List<RemoteRepository>) helper.evaluate( "${project.remoteProjectRepositories}" );
+ repoSystem = helper.getComponent( RepositorySystem.class );
+ }
+ catch ( ExpressionEvaluationException eee )
+ {
+ throw new EnforcerRuleException( "Cannot resolve expression: " + eee.getCause(), eee );
+ }
+ catch ( ComponentLookupException cle )
+ {
+ throw new EnforcerRuleException( "Unable to retrieve component RepositorySystem", cle );
+ }
+ Log log = helper.getLog();
+
+ Collection<DependencySelector> depSelectors = new ArrayList<>();
+ depSelectors.add( new ScopeDependencySelector( excludedScopes ) );
+ if ( !checkOptionals )
+ {
+ depSelectors.add( new OptionalDependencySelector() );
+ }
+ newRepoSession.setDependencySelector( new AndDependencySelector( depSelectors ) );
+
+ Dependency rootDependency = RepositoryUtils.toDependency( project.getArtifact(), null );
+ try
+ {
+ // use root dependency with unresolved direct dependencies
+ int numViolations = emitDependenciesWithBannedDynamicVersions( rootDependency, repoSystem, newRepoSession,
+ remoteRepositories, log );
+ if ( numViolations > 0 )
+ {
+ ChoiceFormat dependenciesFormat = new ChoiceFormat( "1#dependency|1<dependencies" );
+ throw new EnforcerRuleException( "Found " + numViolations + " "
+ + dependenciesFormat.format( numViolations )
+ + " with dynamic versions. Look at the warnings emitted above for the details." );
+ }
+ }
+ catch ( DependencyCollectionException e )
+ {
+ throw new EnforcerRuleException( "Could not retrieve dependency metadata for project : " + e.getMessage(),
+ e );
Review Comment:
Same here, don't duplicate.
##########
enforcer-rules/src/site/apt/banDynamicVersions.apt.vm:
##########
@@ -0,0 +1,108 @@
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+ ------
+ Ban Dynamic Versions
+ ------
+ Konrad Windszus
+ ------
+ October 2022
Review Comment:
Extended ISO date please.
##########
enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/BanDynamicVersions.java:
##########
@@ -0,0 +1,375 @@
+package org.apache.maven.plugins.enforcer;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.text.ChoiceFormat;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.List;
+import java.util.function.Predicate;
+import java.util.stream.Collectors;
+
+import org.apache.maven.RepositoryUtils;
+import org.apache.maven.artifact.versioning.InvalidVersionSpecificationException;
+import org.apache.maven.enforcer.rule.api.EnforcerRuleException;
+import org.apache.maven.enforcer.rule.api.EnforcerRuleHelper;
+import org.apache.maven.plugin.logging.Log;
+import org.apache.maven.plugins.enforcer.utils.ArtifactMatcher;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import org.codehaus.plexus.component.repository.exception.ComponentLookupException;
+import org.eclipse.aether.DefaultRepositorySystemSession;
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.collection.CollectRequest;
+import org.eclipse.aether.collection.CollectResult;
+import org.eclipse.aether.collection.DependencyCollectionException;
+import org.eclipse.aether.collection.DependencySelector;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+import org.eclipse.aether.graph.DependencyVisitor;
+import org.eclipse.aether.repository.RemoteRepository;
+import org.eclipse.aether.util.graph.selector.AndDependencySelector;
+import org.eclipse.aether.util.graph.selector.OptionalDependencySelector;
+import org.eclipse.aether.util.graph.selector.ScopeDependencySelector;
+import org.eclipse.aether.util.graph.visitor.TreeDependencyVisitor;
+import org.eclipse.aether.version.VersionConstraint;
+
+/**
+ * This rule bans dependencies having a version which requires resolution (i.e. dynamic versions which might change with
+ * each build). Dynamic versions are either
+ * <ul>
+ * <li>version ranges,</li>
+ * <li>the special placeholders {@code LATEST} or {@code RELEASE} or</li>
+ * <li>versions ending with {@code -SNAPSHOT}.
+ * </ul>
+ *
+ * @since 3.2.0
+ */
+public class BanDynamicVersions
+ extends AbstractNonCacheableEnforcerRule
+{
+
+ private static final String RELEASE = "RELEASE";
+
+ private static final String LATEST = "LATEST";
+
+ private static final String SNAPSHOT_SUFFIX = "-SNAPSHOT";
+
+ /**
+ * {@code true} if versions ending with {@code -SNAPSHOT} should be allowed
+ */
+ private boolean allowSnapshots;
+
+ /**
+ * {@code true} if versions using {@code LATEST} should be allowed
+ */
+ private boolean allowLatest;
+
+ /**
+ * {@code true} if versions using {@code RELEASE} should be allowed
+ */
+ private boolean allowRelease;
+
+ /**
+ * {@code true} if version ranges should be allowed
+ */
+ private boolean allowRanges;
+
+ /**
+ * {@code true} if also optional dependencies should be checked
+ */
+ private boolean checkOptionals;
+
+ /**
+ * the scopes of dependencies which should be excluded from this rule
+ */
+ private String[] excludedScopes;
+
+ /**
+ * Specify the ignored dependencies. This can be a list of artifacts in the format
+ * <code>groupId[:artifactId][:version]</code>. Any of the sections can be a wildcard by using '*' (ie group:*:1.0)
+ * <br>
+ * The rule will fail if any dependency matches any exclude, unless it also matches an include rule.
+ *
+ * @see {@link #setIgnores(List)}
+ */
+ private List<String> ignores = null;
+
+ public void setIgnores( List<String> ignores )
+ {
+ this.ignores = ignores;
+ }
+
+ public void setAllowSnapshots( boolean allowSnapshots )
+ {
+ this.allowSnapshots = allowSnapshots;
+ }
+
+ public void setAllowLatest( boolean allowLatest )
+ {
+ this.allowLatest = allowLatest;
+ }
+
+ public void setAllowRelease( boolean allowRelease )
+ {
+ this.allowRelease = allowRelease;
+ }
+
+ public void setAllowRanges( boolean allowRanges )
+ {
+ this.allowRanges = allowRanges;
+ }
+
+ public void setCheckOptionals( boolean checkOptionals )
+ {
+ this.checkOptionals = checkOptionals;
+ }
+
+ public void setExcludedScopes( String[] excludedScopes )
+ {
+ this.excludedScopes = excludedScopes;
+ }
+
+ private final class BannedDynamicVersionCollector
+ implements DependencyVisitor
+ {
+
+ private final Log log;
+
+ private final Deque<DependencyNode> nodeStack; // all intermediate nodes (without the root node)
+
+ private boolean isRoot = true;
+
+ private int numViolations;
+
+ private final Predicate<DependencyNode> predicate;
+
+ public int getNumViolations()
+ {
+ return numViolations;
+ }
+
+ BannedDynamicVersionCollector( Log log, Predicate<DependencyNode> predicate )
+ {
+ this.log = log;
+ nodeStack = new ArrayDeque<>();
+ this.predicate = predicate;
+ this.isRoot = true;
+ numViolations = 0;
+ }
+
+ private boolean isBannedDynamicVersion( VersionConstraint versionConstraint )
+ {
+ if ( versionConstraint.getVersion() != null )
+ {
+ if ( versionConstraint.getVersion().toString().equals( LATEST ) )
+ {
+ return !allowLatest;
+ }
+ else if ( versionConstraint.getVersion().toString().equals( RELEASE ) )
+ {
+ return !allowRelease;
+ }
+ else if ( versionConstraint.getVersion().toString().endsWith( SNAPSHOT_SUFFIX ) )
+ {
+ return !allowSnapshots;
+ }
+ }
+ else if ( versionConstraint.getRange() != null )
+ {
+ return !allowRanges;
+ }
+ else
+ {
+ log.warn( "Unexpected version constraint found: " + versionConstraint );
+ }
+ return false;
+
+ }
+
+ @Override
+ public boolean visitEnter( DependencyNode node )
+ {
+ if ( isRoot )
+ {
+ isRoot = false;
+ }
+ else
+ {
+ log.debug( "Found node " + node + " with version constraint " + node.getVersionConstraint() );
+ if ( predicate.test( node ) && isBannedDynamicVersion( node.getVersionConstraint() ) )
+ {
+ MessageBuilder msgBuilder = MessageUtils.buffer();
+ log.warn( msgBuilder.a( "Dependency " )
+ .strong( node.getDependency() )
+ .mojo( dumpIntermediatePath( nodeStack ) )
+ .a( " is referenced with a banned dynamic version " + node.getVersionConstraint() )
+ .toString() );
+ numViolations++;
+ return false;
+ }
+ nodeStack.addLast( node );
+ }
+ return true;
+ }
+
+ @Override
+ public boolean visitLeave( DependencyNode node )
+ {
+ if ( !nodeStack.isEmpty() )
+ {
+ nodeStack.removeLast();
+ }
+ return true;
+ }
+ }
+
+ @SuppressWarnings( "unchecked" )
+ @Override
+ public void execute( EnforcerRuleHelper helper )
+ throws EnforcerRuleException
+ {
+ MavenProject project;
+ DefaultRepositorySystemSession newRepoSession;
+ RepositorySystem repoSystem;
+ List<RemoteRepository> remoteRepositories;
+ try
+ {
+ project = (MavenProject) helper.evaluate( "${project}" );
+ if ( project == null )
+ {
+ throw new ExpressionEvaluationException( "${project} is null" );
+ }
+ RepositorySystemSession repoSession =
+ (RepositorySystemSession) helper.evaluate( "${repositorySystemSession}" );
+ if ( repoSession == null )
+ {
+ throw new ExpressionEvaluationException( "${repositorySystemSession} is null" );
+ }
Review Comment:
Please use `Objects` for these null checks.
##########
enforcer-rules/src/site/apt/banDynamicVersions.apt.vm:
##########
@@ -0,0 +1,108 @@
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+ ------
+ Ban Dynamic Versions
+ ------
+ Konrad Windszus
+ ------
+ October 2022
+ ------
+
+Ban Dynamic Versions
+
+ This rule bans dependencies having versions which require resolution (i.e. dynamic versions which might change with each build). Dynamic versions are either
+
+ * version ranges,
+
+ * the special placeholders <<<LATEST>>>/<<<RELEASE>>> or
+
+ * versions ending with <<<-SNAPSHOT>>>.
+
+ []
+
+ The following parameters are supported by this rule:
+
+ * <<allowSnapshots>> - if <<<true>>> dependencies with versions ending with <<<-SNAPSHOT>>> will not be banned. Default is <<<false>>>.
+
+ * <<allowRelease>> - if <<<true>>> dependencies with version placeholder <<<RELEASE>>> will not be banned. Default is <<<false>>>.
+
+ * <<allowLatest>> - if <<<true>>> dependencies with versions placeholder <<<LATEST>>> will not be banned. Default is <<<false>>>.
+
+ * <<allowRanges>> - if <<<true>>> versions ending with <<<-SNAPSHOT>>> will not be banned. Default is <<<false>>>.
+
+ * <<checkOptionals>> - if <<<true>>> also optional dependencies will be checked. Default is <<<false>>>.
+
+ * <<excludedScopes>> - the list of scopes to exclude;
+
+ * <<ignores>> - a list of dependencies to ignore. The format is <<<groupId[:artifactId][:version][:type][:scope][:classifier]>>> where <<<artifactId>>>, <<<version>>>, <<<type>>>, <<<scope>>> and <<<classifier>>> are optional. Wildcards may be used to replace an entire or just parts of a section.
Review Comment:
This does not correspond to https://github.com/apache/maven-enforcer/pull/187/files#diff-9dd3c382c00a8c5fa752798d8f5e7bae9b72fe5d7454bebf08dc77d1244fe5b4R113.
##########
enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/BanDynamicVersions.java:
##########
@@ -0,0 +1,375 @@
+package org.apache.maven.plugins.enforcer;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.text.ChoiceFormat;
+import java.util.ArrayDeque;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Deque;
+import java.util.List;
+import java.util.function.Predicate;
+import java.util.stream.Collectors;
+
+import org.apache.maven.RepositoryUtils;
+import org.apache.maven.artifact.versioning.InvalidVersionSpecificationException;
+import org.apache.maven.enforcer.rule.api.EnforcerRuleException;
+import org.apache.maven.enforcer.rule.api.EnforcerRuleHelper;
+import org.apache.maven.plugin.logging.Log;
+import org.apache.maven.plugins.enforcer.utils.ArtifactMatcher;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.shared.utils.logging.MessageBuilder;
+import org.apache.maven.shared.utils.logging.MessageUtils;
+import org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
+import org.codehaus.plexus.component.repository.exception.ComponentLookupException;
+import org.eclipse.aether.DefaultRepositorySystemSession;
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.collection.CollectRequest;
+import org.eclipse.aether.collection.CollectResult;
+import org.eclipse.aether.collection.DependencyCollectionException;
+import org.eclipse.aether.collection.DependencySelector;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+import org.eclipse.aether.graph.DependencyVisitor;
+import org.eclipse.aether.repository.RemoteRepository;
+import org.eclipse.aether.util.graph.selector.AndDependencySelector;
+import org.eclipse.aether.util.graph.selector.OptionalDependencySelector;
+import org.eclipse.aether.util.graph.selector.ScopeDependencySelector;
+import org.eclipse.aether.util.graph.visitor.TreeDependencyVisitor;
+import org.eclipse.aether.version.VersionConstraint;
+
+/**
+ * This rule bans dependencies having a version which requires resolution (i.e. dynamic versions which might change with
+ * each build). Dynamic versions are either
+ * <ul>
+ * <li>version ranges,</li>
+ * <li>the special placeholders {@code LATEST} or {@code RELEASE} or</li>
+ * <li>versions ending with {@code -SNAPSHOT}.
+ * </ul>
+ *
+ * @since 3.2.0
+ */
+public class BanDynamicVersions
+ extends AbstractNonCacheableEnforcerRule
+{
+
+ private static final String RELEASE = "RELEASE";
+
+ private static final String LATEST = "LATEST";
+
+ private static final String SNAPSHOT_SUFFIX = "-SNAPSHOT";
+
+ /**
+ * {@code true} if versions ending with {@code -SNAPSHOT} should be allowed
+ */
+ private boolean allowSnapshots;
+
+ /**
+ * {@code true} if versions using {@code LATEST} should be allowed
+ */
+ private boolean allowLatest;
+
+ /**
+ * {@code true} if versions using {@code RELEASE} should be allowed
+ */
+ private boolean allowRelease;
+
+ /**
+ * {@code true} if version ranges should be allowed
+ */
+ private boolean allowRanges;
+
+ /**
+ * {@code true} if also optional dependencies should be checked
+ */
+ private boolean checkOptionals;
+
+ /**
+ * the scopes of dependencies which should be excluded from this rule
+ */
+ private String[] excludedScopes;
+
+ /**
+ * Specify the ignored dependencies. This can be a list of artifacts in the format
+ * <code>groupId[:artifactId][:version]</code>. Any of the sections can be a wildcard by using '*' (ie group:*:1.0)
+ * <br>
+ * The rule will fail if any dependency matches any exclude, unless it also matches an include rule.
+ *
+ * @see {@link #setIgnores(List)}
+ */
+ private List<String> ignores = null;
+
+ public void setIgnores( List<String> ignores )
+ {
+ this.ignores = ignores;
+ }
+
+ public void setAllowSnapshots( boolean allowSnapshots )
+ {
+ this.allowSnapshots = allowSnapshots;
+ }
+
+ public void setAllowLatest( boolean allowLatest )
+ {
+ this.allowLatest = allowLatest;
+ }
+
+ public void setAllowRelease( boolean allowRelease )
+ {
+ this.allowRelease = allowRelease;
+ }
+
+ public void setAllowRanges( boolean allowRanges )
+ {
+ this.allowRanges = allowRanges;
+ }
+
+ public void setCheckOptionals( boolean checkOptionals )
+ {
+ this.checkOptionals = checkOptionals;
+ }
+
+ public void setExcludedScopes( String[] excludedScopes )
+ {
+ this.excludedScopes = excludedScopes;
+ }
+
+ private final class BannedDynamicVersionCollector
+ implements DependencyVisitor
+ {
+
+ private final Log log;
+
+ private final Deque<DependencyNode> nodeStack; // all intermediate nodes (without the root node)
+
+ private boolean isRoot = true;
+
+ private int numViolations;
+
+ private final Predicate<DependencyNode> predicate;
+
+ public int getNumViolations()
+ {
+ return numViolations;
+ }
+
+ BannedDynamicVersionCollector( Log log, Predicate<DependencyNode> predicate )
+ {
+ this.log = log;
+ nodeStack = new ArrayDeque<>();
+ this.predicate = predicate;
+ this.isRoot = true;
+ numViolations = 0;
+ }
+
+ private boolean isBannedDynamicVersion( VersionConstraint versionConstraint )
+ {
+ if ( versionConstraint.getVersion() != null )
+ {
+ if ( versionConstraint.getVersion().toString().equals( LATEST ) )
+ {
+ return !allowLatest;
+ }
+ else if ( versionConstraint.getVersion().toString().equals( RELEASE ) )
+ {
+ return !allowRelease;
+ }
+ else if ( versionConstraint.getVersion().toString().endsWith( SNAPSHOT_SUFFIX ) )
+ {
+ return !allowSnapshots;
+ }
+ }
+ else if ( versionConstraint.getRange() != null )
+ {
+ return !allowRanges;
+ }
+ else
+ {
+ log.warn( "Unexpected version constraint found: " + versionConstraint );
+ }
+ return false;
+
+ }
+
+ @Override
+ public boolean visitEnter( DependencyNode node )
+ {
+ if ( isRoot )
+ {
+ isRoot = false;
+ }
+ else
+ {
+ log.debug( "Found node " + node + " with version constraint " + node.getVersionConstraint() );
+ if ( predicate.test( node ) && isBannedDynamicVersion( node.getVersionConstraint() ) )
+ {
+ MessageBuilder msgBuilder = MessageUtils.buffer();
+ log.warn( msgBuilder.a( "Dependency " )
+ .strong( node.getDependency() )
+ .mojo( dumpIntermediatePath( nodeStack ) )
+ .a( " is referenced with a banned dynamic version " + node.getVersionConstraint() )
+ .toString() );
+ numViolations++;
+ return false;
+ }
+ nodeStack.addLast( node );
+ }
+ return true;
+ }
+
+ @Override
+ public boolean visitLeave( DependencyNode node )
+ {
+ if ( !nodeStack.isEmpty() )
+ {
+ nodeStack.removeLast();
+ }
+ return true;
+ }
+ }
+
+ @SuppressWarnings( "unchecked" )
+ @Override
+ public void execute( EnforcerRuleHelper helper )
+ throws EnforcerRuleException
+ {
+ MavenProject project;
+ DefaultRepositorySystemSession newRepoSession;
+ RepositorySystem repoSystem;
+ List<RemoteRepository> remoteRepositories;
+ try
+ {
+ project = (MavenProject) helper.evaluate( "${project}" );
+ if ( project == null )
+ {
+ throw new ExpressionEvaluationException( "${project} is null" );
+ }
+ RepositorySystemSession repoSession =
+ (RepositorySystemSession) helper.evaluate( "${repositorySystemSession}" );
+ if ( repoSession == null )
+ {
+ throw new ExpressionEvaluationException( "${repositorySystemSession} is null" );
+ }
+ // get a new session to be able to tweak the dependency selector
+ newRepoSession = new DefaultRepositorySystemSession( repoSession );
+ remoteRepositories = (List<RemoteRepository>) helper.evaluate( "${project.remoteProjectRepositories}" );
+ repoSystem = helper.getComponent( RepositorySystem.class );
+ }
+ catch ( ExpressionEvaluationException eee )
+ {
+ throw new EnforcerRuleException( "Cannot resolve expression: " + eee.getCause(), eee );
+ }
+ catch ( ComponentLookupException cle )
+ {
+ throw new EnforcerRuleException( "Unable to retrieve component RepositorySystem", cle );
Review Comment:
Only RS, not the rest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org