[GitHub] [phoenix] BinShi-SecularBird commented on a change in pull request #482: PHOENIX-4925 Use a Variant Segment tree to organize Guide Post Info

[GitBox <gi...@apache.org>]

BinShi-SecularBird commented on a change in pull request #482: PHOENIX-4925 Use a Variant Segment tree to organize Guide Post Info
URL: https://github.com/apache/phoenix/pull/482#discussion_r297326916
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/SnapshotScanner.java
 ##########
 @@ -111,7 +111,11 @@ public SnapshotScanner(Configuration conf, FileSystem fs, Path rootDir,
   public Result next() throws IOException {
     values.clear();
     scanner.nextRaw(values);
-    statisticsCollector.collectStatistics(values);
+    // Needs to call collectStatistics even when values is empty.
+    // In this case, we pass hasMore with value 'false' so a new
+    // guide post will be created for the remaining cached data.
+    statisticsCollector.collectStatistics(values, ! values.isEmpty());
 
 Review comment:
   Adopted the suggestion

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services