[jira] Commented: (FOR-145) Make Forrest able to be imported by Ant

["Thorsten Scherler (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/FOR-145?page=comments#action_12449623 ] 
            
Thorsten Scherler commented on FOR-145:
---------------------------------------

I started to prefix all targets.

An observation is that we now need to add the "forrest." prefix as well calling forrest.

When we did in main/ ./build.sh clean we now have to use ./build.sh forrest.clean 

> Make Forrest able to be imported by Ant
> ---------------------------------------
>
>                 Key: FOR-145
>                 URL: http://issues.apache.org/jira/browse/FOR-145
>             Project: Forrest
>          Issue Type: Bug
>          Components: Compile
>    Affects Versions: 0.7
>            Reporter: Nick Chalko
>            Priority: Minor
>         Attachments: main.build.diff
>
>
> I use an ant build system called antworks,
> http://antworks.sourceforge.net/
>  which includes an antlet for forrest.
> Antlets are included into a projects build file with a ant <import> task.  
> However forrest has many common target names and properties.  
> Please prefix all targets and properties with "forrest." to support using ant import of the entire forrest.build.xml

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] Commented: (FOR-145) Make Forrest able to be imported by Ant

[Thorsten Scherler <th...@juntadeandalucia.es>]

Like you can see I did not commit it yet but made a patch due to the
possible side effects Ross e.g. mentioned.

On Tue, 2006-11-14 at 11:36 +0100, Cyriaque Dupoirieux wrote:
> Ross Gardler a écrit :
> > Thorsten Scherler (JIRA) wrote:
> >>     [ 
> >> http://issues.apache.org/jira/browse/FOR-145?page=comments#action_12449623 
> >> ]             Thorsten Scherler commented on FOR-145:
> >> ---------------------------------------
> >>
> >> I started to prefix all targets.
> >>
> >> An observation is that we now need to add the "forrest." prefix as 
> >> well calling forrest.
> >>
> >> When we did in main/ ./build.sh clean we now have to use ./build.sh 
> >> forrest.clean 
> >
> > This is going to break peoples build systems. Would it be better to 
> > deprecate the none prefixed versions of clean, run, site (and any 
> > others we can think of)?
> >
> > Ross
> >
> >
> Maybe we can alert the user that the target (clean for instance) is 
> deprecated and redirect to the forrest.clean target

The problem with it is that we still have the offending targets in the
ant files. e.g. https://issues.apache.org/jira/browse/FOR-823 If we keep
an init target (deprecated) and do not rename it, it will interfere with
other application (that as well may have an init target).

The only solution I see is to get it done and update the docu. ATM I am
building a new application for a client and I need to have full forrest
as ant. Seeing that the issue is older then 2 years, I am willing to do
the work and basic testing. 

Till we have consensus in the terms of action I will add my work to the
issue tracker as patches.

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)

Re: [jira] Commented: (FOR-145) Make Forrest able to be imported by Ant

[Cyriaque Dupoirieux <Cy...@pcotech.fr>]

Ross Gardler a écrit :
> Thorsten Scherler (JIRA) wrote:
>>     [ 
>> http://issues.apache.org/jira/browse/FOR-145?page=comments#action_12449623 
>> ]             Thorsten Scherler commented on FOR-145:
>> ---------------------------------------
>>
>> I started to prefix all targets.
>>
>> An observation is that we now need to add the "forrest." prefix as 
>> well calling forrest.
>>
>> When we did in main/ ./build.sh clean we now have to use ./build.sh 
>> forrest.clean 
>
> This is going to break peoples build systems. Would it be better to 
> deprecate the none prefixed versions of clean, run, site (and any 
> others we can think of)?
>
> Ross
>
>
Maybe we can alert the user that the target (clean for instance) is 
deprecated and redirect to the forrest.clean target

Salutations,
Cyriaque,

Re: [jira] Commented: (FOR-145) Make Forrest able to be imported by Ant

[Ross Gardler <rg...@apache.org>]

Thorsten Scherler (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/FOR-145?page=comments#action_12449623 ] 
>             
> Thorsten Scherler commented on FOR-145:
> ---------------------------------------
> 
> I started to prefix all targets.
> 
> An observation is that we now need to add the "forrest." prefix as well calling forrest.
> 
> When we did in main/ ./build.sh clean we now have to use ./build.sh forrest.clean 

This is going to break peoples build systems. Would it be better to 
deprecate the none prefixed versions of clean, run, site (and any others 
we can think of)?

Ross