You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/03 13:29:54 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3293: arch/armv6-m: Remove cpsid and cpsie from exception_common

xiaoxiang781216 opened a new pull request #3293:
URL: https://github.com/apache/incubator-nuttx/pull/3293


   ## Summary
   since the hardware do the action automatically
   
   ## Impact
   Should not
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #3293: arch/armv6-m: Remove cpsid and cpsie from exception_common

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3293:
URL: https://github.com/apache/incubator-nuttx/pull/3293#issuecomment-813066064


   Hi @xiaoxiang781216 did you validate it with High Performance / Zero Latency implementation? Maybe it could have some side effect. I need to setup some board with Zero Latency support, I tested it long time ago, I'll not be surprised if it is already damaged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton merged pull request #3293: arch/armv6-m: Remove cpsid and cpsie from exception_common

Posted by GitBox <gi...@apache.org>.
btashton merged pull request #3293:
URL: https://github.com/apache/incubator-nuttx/pull/3293


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3293: arch/armv6-m: Remove cpsid and cpsie from exception_common

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3293:
URL: https://github.com/apache/incubator-nuttx/pull/3293#issuecomment-813068015


   But armv6-m can't support zero latency interrupt, because armv6-m only support PRIMASK(no PRIBASE register):
   https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-m/gnu/arm_exception.S#L80-L82


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #3293: arch/armv6-m: Remove cpsid and cpsie from exception_common

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3293:
URL: https://github.com/apache/incubator-nuttx/pull/3293#issuecomment-813075568


   > But armv6-m can't support zero latency interrupt, because armv6-m only support PRIMASK(no PRIBASE register):
   > https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-m/gnu/arm_exception.S#L80-L82
   
   True! It was for armv7-m!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org