You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "lokeshj1703 (via GitHub)" <gi...@apache.org> on 2024/07/31 11:48:27 UTC
[PR] [HUDI-8035] Fetching commit metadata from timeline fails during upgrade [hudi]
lokeshj1703 opened a new pull request, #11711:
URL: https://github.com/apache/hudi/pull/11711
### Change Logs
If the table has all timeline instants files with the older format without completion time, the upgrade fails because org.apache.hudi.common.table.timeline.HoodieActiveTimeline#getInstantDetails is trying to read file with completion time.
### Impact
NA
### Risk level (write none, low medium or high below)
low
### Documentation Update
NA
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8035] Fetching commit metadata from timeline fails during upgrade [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #11711:
URL: https://github.com/apache/hudi/pull/11711#issuecomment-2261904051
> Are we sure that if completion time is null, the callers of the API would be able to handle it?
Yes, the 0.x code would filter all the completed instants first before it fetches the completion time(state transition time).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8035] Fetching commit metadata from timeline fails during upgrade [hudi]
Posted by "lokeshj1703 (via GitHub)" <gi...@apache.org>.
lokeshj1703 commented on PR #11711:
URL: https://github.com/apache/hudi/pull/11711#issuecomment-2261806130
@danny0405 I see a revert in your patch -
```
public String getCompletionTime() {
- return completionTime != null ? completionTime : stateTransitionTime;
+ return completionTime;
}
```
Earlier implementation used `stateTransitionTime` for this function. The new implementation renamed the function from `getStateTransitionTime` to `getCompletionTime`. Are we sure that if completion time is null, the callers of the API would be able to handle it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8035] Fetching commit metadata from timeline fails during upgrade [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11711:
URL: https://github.com/apache/hudi/pull/11711#issuecomment-2260479873
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f8208fead79c619482cb15a9742de479cac752c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f8208fead79c619482cb15a9742de479cac752c",
"triggerType" : "PUSH"
}, {
"hash" : "0997c440651723b1c8e56d6484c9cda936666f14",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0997c440651723b1c8e56d6484c9cda936666f14",
"triggerType" : "PUSH"
}, {
"hash" : "7862145fcda90818d9916821179b94430e040e54",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25043",
"triggerID" : "7862145fcda90818d9916821179b94430e040e54",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f8208fead79c619482cb15a9742de479cac752c UNKNOWN
* 0997c440651723b1c8e56d6484c9cda936666f14 UNKNOWN
* 7862145fcda90818d9916821179b94430e040e54 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25043)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8035] Fetching commit metadata from timeline fails during upgrade [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11711:
URL: https://github.com/apache/hudi/pull/11711#issuecomment-2260361983
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f8208fead79c619482cb15a9742de479cac752c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f8208fead79c619482cb15a9742de479cac752c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f8208fead79c619482cb15a9742de479cac752c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8035] Fetching commit metadata from timeline fails during upgrade [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11711:
URL: https://github.com/apache/hudi/pull/11711#issuecomment-2262298223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f8208fead79c619482cb15a9742de479cac752c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f8208fead79c619482cb15a9742de479cac752c",
"triggerType" : "PUSH"
}, {
"hash" : "0997c440651723b1c8e56d6484c9cda936666f14",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0997c440651723b1c8e56d6484c9cda936666f14",
"triggerType" : "PUSH"
}, {
"hash" : "7862145fcda90818d9916821179b94430e040e54",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25043",
"triggerID" : "7862145fcda90818d9916821179b94430e040e54",
"triggerType" : "PUSH"
}, {
"hash" : "1ea4712f0fb4c087d06c4ba024165fe7b2ad457b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25047",
"triggerID" : "1ea4712f0fb4c087d06c4ba024165fe7b2ad457b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f8208fead79c619482cb15a9742de479cac752c UNKNOWN
* 0997c440651723b1c8e56d6484c9cda936666f14 UNKNOWN
* 1ea4712f0fb4c087d06c4ba024165fe7b2ad457b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25047)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8035] Fetching commit metadata from timeline fails during upgrade [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11711:
URL: https://github.com/apache/hudi/pull/11711#issuecomment-2260377846
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f8208fead79c619482cb15a9742de479cac752c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f8208fead79c619482cb15a9742de479cac752c",
"triggerType" : "PUSH"
}, {
"hash" : "0997c440651723b1c8e56d6484c9cda936666f14",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0997c440651723b1c8e56d6484c9cda936666f14",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f8208fead79c619482cb15a9742de479cac752c UNKNOWN
* 0997c440651723b1c8e56d6484c9cda936666f14 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8035] Fetching commit metadata from timeline fails during upgrade [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #11711:
URL: https://github.com/apache/hudi/pull/11711#issuecomment-2261754028
@lokeshj1703 Thanks for the contribution, I have reviewed and applied a patch:
[8035.patch.zip](https://github.com/user-attachments/files/16448522/8035.patch.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8035] Fetching commit metadata from timeline fails during upgrade [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11711:
URL: https://github.com/apache/hudi/pull/11711#issuecomment-2260497259
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f8208fead79c619482cb15a9742de479cac752c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f8208fead79c619482cb15a9742de479cac752c",
"triggerType" : "PUSH"
}, {
"hash" : "0997c440651723b1c8e56d6484c9cda936666f14",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0997c440651723b1c8e56d6484c9cda936666f14",
"triggerType" : "PUSH"
}, {
"hash" : "7862145fcda90818d9916821179b94430e040e54",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25043",
"triggerID" : "7862145fcda90818d9916821179b94430e040e54",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f8208fead79c619482cb15a9742de479cac752c UNKNOWN
* 0997c440651723b1c8e56d6484c9cda936666f14 UNKNOWN
* 7862145fcda90818d9916821179b94430e040e54 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25043)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8035] Fetching commit metadata from timeline fails during upgrade [hudi]
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope merged PR #11711:
URL: https://github.com/apache/hudi/pull/11711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8035] Fetching commit metadata from timeline fails during upgrade [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11711:
URL: https://github.com/apache/hudi/pull/11711#issuecomment-2260462273
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f8208fead79c619482cb15a9742de479cac752c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f8208fead79c619482cb15a9742de479cac752c",
"triggerType" : "PUSH"
}, {
"hash" : "0997c440651723b1c8e56d6484c9cda936666f14",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0997c440651723b1c8e56d6484c9cda936666f14",
"triggerType" : "PUSH"
}, {
"hash" : "7862145fcda90818d9916821179b94430e040e54",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7862145fcda90818d9916821179b94430e040e54",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f8208fead79c619482cb15a9742de479cac752c UNKNOWN
* 0997c440651723b1c8e56d6484c9cda936666f14 UNKNOWN
* 7862145fcda90818d9916821179b94430e040e54 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8035] Fetching commit metadata from timeline fails during upgrade [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11711:
URL: https://github.com/apache/hudi/pull/11711#issuecomment-2262129276
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f8208fead79c619482cb15a9742de479cac752c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f8208fead79c619482cb15a9742de479cac752c",
"triggerType" : "PUSH"
}, {
"hash" : "0997c440651723b1c8e56d6484c9cda936666f14",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0997c440651723b1c8e56d6484c9cda936666f14",
"triggerType" : "PUSH"
}, {
"hash" : "7862145fcda90818d9916821179b94430e040e54",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25043",
"triggerID" : "7862145fcda90818d9916821179b94430e040e54",
"triggerType" : "PUSH"
}, {
"hash" : "1ea4712f0fb4c087d06c4ba024165fe7b2ad457b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ea4712f0fb4c087d06c4ba024165fe7b2ad457b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f8208fead79c619482cb15a9742de479cac752c UNKNOWN
* 0997c440651723b1c8e56d6484c9cda936666f14 UNKNOWN
* 7862145fcda90818d9916821179b94430e040e54 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25043)
* 1ea4712f0fb4c087d06c4ba024165fe7b2ad457b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8035] Fetching commit metadata from timeline fails during upgrade [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11711:
URL: https://github.com/apache/hudi/pull/11711#issuecomment-2262141354
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f8208fead79c619482cb15a9742de479cac752c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f8208fead79c619482cb15a9742de479cac752c",
"triggerType" : "PUSH"
}, {
"hash" : "0997c440651723b1c8e56d6484c9cda936666f14",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0997c440651723b1c8e56d6484c9cda936666f14",
"triggerType" : "PUSH"
}, {
"hash" : "7862145fcda90818d9916821179b94430e040e54",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25043",
"triggerID" : "7862145fcda90818d9916821179b94430e040e54",
"triggerType" : "PUSH"
}, {
"hash" : "1ea4712f0fb4c087d06c4ba024165fe7b2ad457b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25047",
"triggerID" : "1ea4712f0fb4c087d06c4ba024165fe7b2ad457b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f8208fead79c619482cb15a9742de479cac752c UNKNOWN
* 0997c440651723b1c8e56d6484c9cda936666f14 UNKNOWN
* 7862145fcda90818d9916821179b94430e040e54 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25043)
* 1ea4712f0fb4c087d06c4ba024165fe7b2ad457b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25047)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org