[GitHub] [skywalking-python] wu-sheng commented on a diff in pull request #231: feat: Add support for MeterReportService

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #231:
URL: https://github.com/apache/skywalking-python/pull/231#discussion_r1124406396


##########
skywalking/client/__init__.py:
##########
@@ -28,6 +28,9 @@ class TraceSegmentReportService(object):
     def report(self, generator):
         raise NotImplementedError()
 
+class MeterReportService(object):
+    def report(self, generator):

Review Comment:
   Learn MAL and Dashboard setup.
   - https://skywalking.apache.org/docs/main/next/en/setup/backend/backend-meter/
   - https://skywalking.apache.org/docs/main/next/en/concepts-and-designs/mal/
   - Examples, https://github.com/apache/skywalking/tree/89d14e6256338840cd4a9b37f76980c8558e50c3/oap-server/server-starter/src/main/resources/meter-analyzer-config/
   - Dashboard, https://skywalking.apache.org/docs/main/next/en/ui/readme/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org