You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by Xuanwo <xu...@apache.org> on 2024/10/08 07:55:46 UTC
[DISCUSS] Drop pypy 3.9 tests for avro python
Hi,
Our CI failed for a long time because PyPy-3.9 doesn't have a pre-built Cramjam, as I discovered in this comment [1].
I initiated a discussion [2] with Cramjam's maintainer and found that it's the PyPy team's policy to support only one version, and they are planning to deprecate PyPy 3.9 [3].
I'm writing this thread to discuss whether it's a good idea for us to drop the tests on PyPy 3.9.
I'm willing to implement this change.
[1]: https://github.com/apache/avro/pull/3199#issuecomment-2399030073
[2]: https://github.com/milesgranger/cramjam/issues/185
[3]: https://pypy.org/posts/2024/08/pypy-v7317-release.html
Xuanwo
https://xuanwo.io/
Re: [DISCUSS] Drop pypy 3.9 tests for avro python
Posted by "Michael A. Smith" <mi...@smith-li.com>.
+1
We could dig up the old vote about our strategy here, but I'm sure there's
no conflict.
On Wed, Oct 9, 2024 at 12:11 Oscar Westra van Holthe - Kind <
oscar@westravanholthe.nl> wrote:
> +1 from me as well. The maintainers argument Martin mentioned is a strong
> one.
>
> Upgrading the Python versions we mention and use in a separate PR is also a
> good idea.
>
>
> Kind regards,
> Oscar
>
> --
> Oscar Westra van Holthe - Kind <os...@westravanholthe.nl>
>
> Op wo 9 okt. 2024 10:08 schreef Martin Grigorov <mg...@apache.org>:
>
> > Hi,
> >
> > I'm +1 for dropping PyPy 3.9 since it is no longer supported by its
> > maintainers.
> >
> > Side note: I just love how things start breaking without any change in
> our
> > code...
> > This is why I prefer setting exact versions of the dependencies and
> > manually update them if the new version does not break (
> > https://github.com/apache/avro-rs/issues/4)
> >
> > AFAIK Python 3.8 is also EOL-ed but we still mention even 3.7 at
> >
> >
> https://github.com/apache/avro/blob/9304cb793aee4d5b1da56b1dced3b7e65329779f/lang/py/setup.cfg#L36-L37
> > Dropping 3.7/3.8 and adding 3.12/3.13 should be done in a separate PR.
> >
> > On Tue, Oct 8, 2024 at 11:24 AM Xuanwo <xu...@apache.org> wrote:
> >
> > > Hi,
> > >
> > > Our CI failed for a long time because PyPy-3.9 doesn't have a pre-built
> > > Cramjam, as I discovered in this comment [1].
> > >
> > > I initiated a discussion [2] with Cramjam's maintainer and found that
> > it's
> > > the PyPy team's policy to support only one version, and they are
> planning
> > > to deprecate PyPy 3.9 [3].
> > >
> > > I'm writing this thread to discuss whether it's a good idea for us to
> > drop
> > > the tests on PyPy 3.9.
> > >
> > > I'm willing to implement this change.
> > >
> > > [1]: https://github.com/apache/avro/pull/3199#issuecomment-2399030073
> > > [2]: https://github.com/milesgranger/cramjam/issues/185
> > > [3]: https://pypy.org/posts/2024/08/pypy-v7317-release.html
> > >
> > > Xuanwo
> > >
> > > https://xuanwo.io/
> > >
> >
>
Re: [DISCUSS] Drop pypy 3.9 tests for avro python
Posted by Oscar Westra van Holthe - Kind <os...@westravanholthe.nl>.
+1 from me as well. The maintainers argument Martin mentioned is a strong
one.
Upgrading the Python versions we mention and use in a separate PR is also a
good idea.
Kind regards,
Oscar
--
Oscar Westra van Holthe - Kind <os...@westravanholthe.nl>
Op wo 9 okt. 2024 10:08 schreef Martin Grigorov <mg...@apache.org>:
> Hi,
>
> I'm +1 for dropping PyPy 3.9 since it is no longer supported by its
> maintainers.
>
> Side note: I just love how things start breaking without any change in our
> code...
> This is why I prefer setting exact versions of the dependencies and
> manually update them if the new version does not break (
> https://github.com/apache/avro-rs/issues/4)
>
> AFAIK Python 3.8 is also EOL-ed but we still mention even 3.7 at
>
> https://github.com/apache/avro/blob/9304cb793aee4d5b1da56b1dced3b7e65329779f/lang/py/setup.cfg#L36-L37
> Dropping 3.7/3.8 and adding 3.12/3.13 should be done in a separate PR.
>
> On Tue, Oct 8, 2024 at 11:24 AM Xuanwo <xu...@apache.org> wrote:
>
> > Hi,
> >
> > Our CI failed for a long time because PyPy-3.9 doesn't have a pre-built
> > Cramjam, as I discovered in this comment [1].
> >
> > I initiated a discussion [2] with Cramjam's maintainer and found that
> it's
> > the PyPy team's policy to support only one version, and they are planning
> > to deprecate PyPy 3.9 [3].
> >
> > I'm writing this thread to discuss whether it's a good idea for us to
> drop
> > the tests on PyPy 3.9.
> >
> > I'm willing to implement this change.
> >
> > [1]: https://github.com/apache/avro/pull/3199#issuecomment-2399030073
> > [2]: https://github.com/milesgranger/cramjam/issues/185
> > [3]: https://pypy.org/posts/2024/08/pypy-v7317-release.html
> >
> > Xuanwo
> >
> > https://xuanwo.io/
> >
>
Re: [DISCUSS] Drop pypy 3.9 tests for avro python
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
I'm +1 for dropping PyPy 3.9 since it is no longer supported by its
maintainers.
Side note: I just love how things start breaking without any change in our
code...
This is why I prefer setting exact versions of the dependencies and
manually update them if the new version does not break (
https://github.com/apache/avro-rs/issues/4)
AFAIK Python 3.8 is also EOL-ed but we still mention even 3.7 at
https://github.com/apache/avro/blob/9304cb793aee4d5b1da56b1dced3b7e65329779f/lang/py/setup.cfg#L36-L37
Dropping 3.7/3.8 and adding 3.12/3.13 should be done in a separate PR.
On Tue, Oct 8, 2024 at 11:24 AM Xuanwo <xu...@apache.org> wrote:
> Hi,
>
> Our CI failed for a long time because PyPy-3.9 doesn't have a pre-built
> Cramjam, as I discovered in this comment [1].
>
> I initiated a discussion [2] with Cramjam's maintainer and found that it's
> the PyPy team's policy to support only one version, and they are planning
> to deprecate PyPy 3.9 [3].
>
> I'm writing this thread to discuss whether it's a good idea for us to drop
> the tests on PyPy 3.9.
>
> I'm willing to implement this change.
>
> [1]: https://github.com/apache/avro/pull/3199#issuecomment-2399030073
> [2]: https://github.com/milesgranger/cramjam/issues/185
> [3]: https://pypy.org/posts/2024/08/pypy-v7317-release.html
>
> Xuanwo
>
> https://xuanwo.io/
>