[GitHub] [trafficserver] SolidWallOfCode commented on pull request #7090: Cleans up duplicated TSOutboundConnectionMatchType definition

[GitBox <gi...@apache.org>]

SolidWallOfCode commented on pull request #7090:
URL: https://github.com/apache/trafficserver/pull/7090#issuecomment-672859216


   I'm trying to remember. Clearly the enum is in "apidefs.h" so it is available to plugins. I think it was elsewhere both because of legacy (it had always been there) and to avoid additional dependencies (e.g., any core code that needs to use those values must include all of "apidefs.h"). Maybe things have changed elsewhere, but I know I tried doing this earlier and it didn't compile for lack of that include, but I don't see such a change in your PR. If this works without such a change it seems reasonable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org