You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/04 04:06:40 UTC
[GitHub] [helix] pkuwm opened a new pull request #853: Fix type cast in
TestRawZkClient
pkuwm opened a new pull request #853: Fix type cast in TestRawZkClient
URL: https://github.com/apache/helix/pull/853
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Fixes #852
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
The type cast is unexpected. We would like to make the test accurate and expected.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- [ ] The following is the result of the "mvn test" command on the appropriate module:
Running...
### Commits
- [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation (Optional)
- [ ] In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Code Quality
- [ ] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #853: Fix type cast in
TestRawZkClient
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #853: Fix type cast in TestRawZkClient
URL: https://github.com/apache/helix/pull/853
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on issue #853: Fix type cast in
TestRawZkClient
Posted by GitBox <gi...@apache.org>.
pkuwm commented on issue #853: Fix type cast in TestRawZkClient
URL: https://github.com/apache/helix/pull/853#issuecomment-594726255
This PR is ready to be merged, approved by @jiajunwang
```
The type cast from char to int is unexpected in testAsyncWriteOperations. We would like to fix it and make the type cast expected and the test accurate.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org