You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/12/17 13:17:26 UTC
Review Request 29151: CLOUDSTACK-8084: Fixed
test_17_add_nic_different_zone in test_add_remove_network.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29151/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8084
https://issues.apache.org/jira/browse/CLOUDSTACK-8084
Repository: cloudstack-git
Description
-------
The network was created within root admin account, so it had a risk of getting used by other test cases by default. In that case cleanup would fail.
Created the network in account created by the test case.
Diffs
-----
test/integration/component/test_add_remove_network.py aacd44b
Diff: https://reviews.apache.org/r/29151/diff/
Testing
-------
Yes.
Log:
Add network to vm where both belong to different zones ... === TestName: test_17_add_nic_different_zone | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 308.910s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 29151: CLOUDSTACK-8084: Fixed
test_17_add_nic_different_zone in test_add_remove_network.py
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29151/#review65604
-----------------------------------------------------------
Ship it!
3090e4a0301c4be50d0d46703b2d9fa070c2e91b master
0db63d87aa40de7493a6bc66b7686cf8922bc742 4.5
- SrikanteswaraRao Talluri
On Dec. 17, 2014, 12:17 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29151/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2014, 12:17 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8084
> https://issues.apache.org/jira/browse/CLOUDSTACK-8084
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The network was created within root admin account, so it had a risk of getting used by other test cases by default. In that case cleanup would fail.
>
> Created the network in account created by the test case.
>
>
> Diffs
> -----
>
> test/integration/component/test_add_remove_network.py aacd44b
>
> Diff: https://reviews.apache.org/r/29151/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Add network to vm where both belong to different zones ... === TestName: test_17_add_nic_different_zone | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 308.910s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>