[jira] [Updated] (AVRO-680) Allow for non-string keys

["Sachin Goyal (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AVRO-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sachin Goyal updated AVRO-680:
------------------------------
    Attachment: AVRO-680.patch

[~rdblue], here is a new patch with the above suggestions.

Main change is in getNameForNonStringMapRecord():
{code:java}
if (keyType instanceof Class && valueType instanceof Class) {
        Class keyClass = (Class)keyType;
        Class valueClass = (Class)valueType;
        if (keyClass.getPackage().equals(JAVA_LANG_PKG) &&
            valueClass.getPackage().equals(JAVA_LANG_PKG)) {
            return NS_MAP_ARRAY_RECORD +
                keyClass.getSimpleName() + valueClass.getSimpleName();
        }
}
{code}

So it generates names like PairIntegerString for all classes inside the java.lang package.
A test for the same has also been added in the new patch.

The RuntimeException is also fixed.

> Allow for non-string keys
> -------------------------
>
>                 Key: AVRO-680
>                 URL: https://issues.apache.org/jira/browse/AVRO-680
>             Project: Avro
>          Issue Type: Improvement
>    Affects Versions: 1.7.6, 1.7.7
>            Reporter: Jeremy Hanna
>         Attachments: AVRO-680.patch, AVRO-680.patch, AVRO-680.patch, PERF_8000_cycles.zip, isMap_Call_Hierarchy.png, non_string_map_keys.zip, non_string_map_keys2.zip, non_string_map_keys3.zip, non_string_map_keys4.patch, non_string_map_keys5.patch, non_string_map_keys6.patch, non_string_map_keys7.patch, non_string_map_perf.txt, non_string_map_perf2.txt, original_perf.txt
>
>
> Based on an email thread back in April, Doug Cutting proposed a possible solution for having non-string keys:
> Stu Hood wrote:
> > I can understand the reasoning behind AVRO-9, but now I need to look for an alternative to a 'map' that will allow me to store an association of bytes keys to values.
> A map of Foo has the same binary format as an array of records, each
> with a string field and a Foo field.  So an application can use an array
> schema similar to this to represent map-like structures with, e.g.,
> non-string keys.
> Perhaps we could establish standard properties that indicate that a
> given array of records should be represented in a map-like way if
> possible?  E.g.,:
> {"type": "array", "isMap": true, "items": {"type":"record", ...}}
> Doug



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)