[jira] Closed: (MSITE-303) Discard invalid characters from directory name generated for staging site

["Benjamin Bentmann (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/MSITE-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MSITE-303.
-----------------------------------

         Assignee: Benjamin Bentmann
       Resolution: Fixed
    Fix Version/s: 2.0-beta-7

Fixed in [r651407|http://svn.apache.org/viewvc?view=rev&revision=651407].

> Discard invalid characters from directory name generated for staging site
> -------------------------------------------------------------------------
>
>                 Key: MSITE-303
>                 URL: http://jira.codehaus.org/browse/MSITE-303
>             Project: Maven 2.x Site Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.0-beta-6
>            Reporter: Benjamin Bentmann
>            Assignee: Benjamin Bentmann
>            Priority: Trivial
>             Fix For: 2.0-beta-7
>
>         Attachments: filter-invalid-chars.patch
>
>
> {{site-stage}} takes the distribution URL and builds a filesystem path from it. This can potentially lead to invalid paths since URLs may contain characters that are not valid for directory names.
> It's mostly a theoretical issue since good URLs don't include bad characters. The only exploit I can offer is to set the distribution URL to something like {{file://G:/Sites/}} on a Windows box which then will cause an invalid file name like {{G:\Sites\stage\localhost\G:\Sites\multi-module-project\index.html}}. I experienced this during some local quick&dirty testing.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira