You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/22 08:57:00 UTC

[GitHub] [iotdb] Alima777 opened a new pull request #1845: [IOTDB-955] Add more tracing log

Alima777 opened a new pull request #1845:
URL: https://github.com/apache/iotdb/pull/1845


   Add statistics(start time and end time) of each device in tsfile.
   Replace end time with total cost time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] JackieTien97 merged pull request #1845: [IOTDB-955] Add more tracing log

Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #1845:
URL: https://github.com/apache/iotdb/pull/1845


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] Alima777 commented on a change in pull request #1845: [IOTDB-955] Add more tracing log

Posted by GitBox <gi...@apache.org>.
Alima777 commented on a change in pull request #1845:
URL: https://github.com/apache/iotdb/pull/1845#discussion_r510826050



##########
File path: docs/zh/UserGuide/System Tools/Performance Tracing Tool.md
##########
@@ -35,12 +35,13 @@ IoTDB 支持使用 `TRACING` 语句来启用/禁用对查询语句的性能追
 - Start time
 - Query statement
 - Number of series paths
-- Number of tsfiles
 - Number of sequence files
+- Statistics of each sequence file
 - Number of unsequence files
+- Statistics of each sequence file

Review comment:
       Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] JackieTien97 commented on a change in pull request #1845: [IOTDB-955] Add more tracing log

Posted by GitBox <gi...@apache.org>.
JackieTien97 commented on a change in pull request #1845:
URL: https://github.com/apache/iotdb/pull/1845#discussion_r510621059



##########
File path: docs/UserGuide/System Tools/Performance Tracing Tool.md
##########
@@ -30,17 +30,18 @@ Turn off Tracing:
 
 `IoTDB> TRACING OFF`
 
-Since the cost of an IoTDB query mainly depends on the number of time series queried, the number of tsfile files accessed, the total number of chunks to be scanned and the average size of each chunk (the number of data points contained in the chunk). Therefore, the current performance analysis includes the following contents:
+Since the cost of an IoTDB query mainly depends on the number of time series queried, the number of tsfile files accessed, the total number of chunks to be scanned, and the average size of each chunk (the number of data points contained in the chunk). Therefore, the current performance analysis includes the following contents:
 
 - Start time
 - Query statement
 - Number of series paths
-- Number of tsfiles
 - Number of sequence files
+- Statistics of each sequence file
 - Number of unsequence files
+- Statistics of each sequence file

Review comment:
       ```suggestion
   - Statistics of each unsequence file
   ```

##########
File path: docs/zh/UserGuide/System Tools/Performance Tracing Tool.md
##########
@@ -35,12 +35,13 @@ IoTDB 支持使用 `TRACING` 语句来启用/禁用对查询语句的性能追
 - Start time
 - Query statement
 - Number of series paths
-- Number of tsfiles
 - Number of sequence files
+- Statistics of each sequence file
 - Number of unsequence files
+- Statistics of each sequence file

Review comment:
       ```suggestion
   - Statistics of each unsequence file
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org