You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/20 23:36:43 UTC
[GitHub] [airflow] gmontanola opened a new pull request #10436: Fixes S3ToRedshift COPY query
gmontanola opened a new pull request #10436:
URL: https://github.com/apache/airflow/pull/10436
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
The query templated inside the operator was **appending the target table name to the S3 object key**. This is just a minor typo but it breaks the operator functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #10436: Fixes S3ToRedshift COPY query
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #10436:
URL: https://github.com/apache/airflow/pull/10436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10436: Fixes S3ToRedshift COPY query
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10436:
URL: https://github.com/apache/airflow/pull/10436#issuecomment-677957800
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10436: Fixes S3ToRedshift COPY query
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10436:
URL: https://github.com/apache/airflow/pull/10436#issuecomment-678059543
Hey @gmontanola. I am afraid the s3_to_redshift tests are failing - you will need to fix them in this PR as well https://github.com/apache/airflow/blob/88c7d2e526af4994066f65f830e2fa8edcbbce2e/tests/providers/amazon/aws/transfers/test_s3_to_redshift.py#L58 . Happy to help if you need to run it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gmontanola commented on pull request #10436: Fixes S3ToRedshift COPY query
Posted by GitBox <gi...@apache.org>.
gmontanola commented on pull request #10436:
URL: https://github.com/apache/airflow/pull/10436#issuecomment-678138790
Oh, my bad! I'll do it ASAP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gmontanola commented on pull request #10436: Fixes S3ToRedshift COPY query
Posted by GitBox <gi...@apache.org>.
gmontanola commented on pull request #10436:
URL: https://github.com/apache/airflow/pull/10436#issuecomment-678473322
Haha, the emojis are a courtesy of https://github.com/commitizen/cz-cli.
When you say if it is backwards compatible you mean if it will work with older versions? Well, since it was only a typo, if the Operator "worked" on older versions, it will work now, but properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10436: Fixes S3ToRedshift COPY query
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10436:
URL: https://github.com/apache/airflow/pull/10436#issuecomment-678681300
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org