You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/18 07:06:03 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #15418: Parse Error 410 in kubernetes Watcher and return latest resource version
ephraimbuddy opened a new pull request #15418:
URL: https://github.com/apache/airflow/pull/15418
Currently, when kubernetes watcher stream encounter Error 410('too old resource version'),
it returns resource version '0' which is not the latest version.
This 410 error contains the latest resource version in its message.
This PR parses the message and return the latest resource version so that
watcher can continue watching instead of returning '0'
Some relevant links on this:
https://github.com/kubernetes-client/python/issues/609
https://github.com/kubernetes-client/python/issues/728#issuecomment-561134890
This would likely fix some issues #14175 and #13916
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #15418: Parse Error 410 in kubernetes Watcher and return latest resource version
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #15418:
URL: https://github.com/apache/airflow/pull/15418#issuecomment-827018280
> @ephraimbuddy is there a case where we would get a 410 for a different reason? I feel hesitant to exactly parse an error in case the k8s folks change the wording.
Hi @dimberman , it's now being addressed here: https://github.com/apache/airflow/pull/15500. The PR will close this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #15418: Parse Error 410 in kubernetes Watcher and return latest resource version
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #15418:
URL: https://github.com/apache/airflow/pull/15418#issuecomment-827016884
@ephraimbuddy is there a case where we would get a 410 for a different reason? I feel hesitant to exactly parse an error in case the k8s folks change the wording.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy closed pull request #15418: Parse Error 410 in kubernetes Watcher and return latest resource version
Posted by GitBox <gi...@apache.org>.
ephraimbuddy closed pull request #15418:
URL: https://github.com/apache/airflow/pull/15418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org