You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/06/03 23:36:03 UTC
[kudu-CR](branch-1.15.x) KUDU-3265 txn-related options to 'kudu perf loadgen'
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17540
Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen'
......................................................................
KUDU-3265 txn-related options to 'kudu perf loadgen'
This patch adds the following txn-related options to the
'kudu perf loadgen' tool:
(1) --txn_start
(2) --txn_commit
(3) --txn_rollback
With those, it's possible to insert rows into the table in the scope
of a multi-row transaction, and then (1) leave the transaction
as is, or (2) commit the transaction, or (3) rollback the transaction
explicitly.
Semantically, specifying --txn_commit or --txn_rollback implies setting
--txn_start as well.
This patch partially addresses KUDU-3265. A follow-up patch will add
functionality to write and read transactional tokens in serialized form,
so the newly introduced --txn_start option starts making more sense.
With that, it will be possible to start a new multi-row transaction
in one session of the kudu CLI tool, and then continue adding more rows
in another session of the kudu CLI tool, passing around transactional
token.
Change-Id: I73750af589d432c6ae973439264f55c08a327aa7
Reviewed-on: http://gerrit.cloudera.org:8080/17526
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit e574903ace741a531c49aba15f97e856ea80ca4b)
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_perf.cc
2 files changed, 262 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/17540/1
--
To view, visit http://gerrit.cloudera.org:8080/17540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73750af589d432c6ae973439264f55c08a327aa7
Gerrit-Change-Number: 17540
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR](branch-1.15.x) KUDU-3265 txn-related options to 'kudu perf loadgen'
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17540 )
Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen'
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I73750af589d432c6ae973439264f55c08a327aa7
Gerrit-Change-Number: 17540
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Jun 2021 13:26:08 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) KUDU-3265 txn-related options to 'kudu perf loadgen'
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17540 )
Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen'
......................................................................
Patch Set 1: Code-Review+2
While not absolutely critical, if we haven't put together RC2 yet, it'd be really nice to include this patch for testing and demo purposes. Will defer to Bankim though as RM.
--
To view, visit http://gerrit.cloudera.org:8080/17540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I73750af589d432c6ae973439264f55c08a327aa7
Gerrit-Change-Number: 17540
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Jun 2021 00:33:46 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) KUDU-3265 txn-related options to 'kudu perf loadgen'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17540 )
Change subject: KUDU-3265 txn-related options to 'kudu perf loadgen'
......................................................................
KUDU-3265 txn-related options to 'kudu perf loadgen'
This patch adds the following txn-related options to the
'kudu perf loadgen' tool:
(1) --txn_start
(2) --txn_commit
(3) --txn_rollback
With those, it's possible to insert rows into the table in the scope
of a multi-row transaction, and then (1) leave the transaction
as is, or (2) commit the transaction, or (3) rollback the transaction
explicitly.
Semantically, specifying --txn_commit or --txn_rollback implies setting
--txn_start as well.
This patch partially addresses KUDU-3265. A follow-up patch will add
functionality to write and read transactional tokens in serialized form,
so the newly introduced --txn_start option starts making more sense.
With that, it will be possible to start a new multi-row transaction
in one session of the kudu CLI tool, and then continue adding more rows
in another session of the kudu CLI tool, passing around transactional
token.
Change-Id: I73750af589d432c6ae973439264f55c08a327aa7
Reviewed-on: http://gerrit.cloudera.org:8080/17526
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit e574903ace741a531c49aba15f97e856ea80ca4b)
Reviewed-on: http://gerrit.cloudera.org:8080/17540
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_perf.cc
2 files changed, 262 insertions(+), 28 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
Bankim Bhavsar: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I73750af589d432c6ae973439264f55c08a327aa7
Gerrit-Change-Number: 17540
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)