You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Magyar <am...@hortonworks.com> on 2017/06/26 16:23:27 UTC
Review Request 60431: Cleanup relevant Kerberos identities when a
component is removed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60431/
-----------------------------------------------------------
Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Laszlo Puskas, Robert Levas, and Sebastian Toader.
Bugs: AMBARI-21343
https://issues.apache.org/jira/browse/AMBARI-21343
Repository: ambari
Description
-------
Upon removing a component from a host, the relevant Kerberos identities should be removed as well. This includes any principals and keytab files. Care must be taken not to remove any principals or keytab files that are still in use in the cluster.
Entry point is KerberosIdentityCleaner>>componentRemoved. It removes all of the identities of the uninstalled component, except the ones that are still used by other services/components.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e8c986b
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java d000571
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 802c93d
ambari-server/src/main/java/org/apache/ambari/server/controller/OrderedRequestStageContainer.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 7824019
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 9755bd6
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java 2112fcc
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java ca9f013
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java 86a5e01
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java a606954
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java 0f14ca6
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java PRE-CREATION
ambari-web/app/controllers/main/service/item.js 09c7a9c
Diff: https://reviews.apache.org/r/60431/diff/1/
Testing
-------
Added new unittests
End to end tested manually:
before all:
- created a cluster with oozie
- enabled kerberos
1.
- removed oozie
- checked if oozie_server principal and keytab was removed, and other identites weren't touched
2.
- made the kdc admin credentials expired
- removed oozie
- supplied kdc admin credentials on the ui
- checked if oozie_server principal and keytab was removed
3.
- added oozie_server principal to a kerberos.json of an other service (so that the principal was shared)
- removed oozie
- checked if the oozie_server principal and keytab was NOT removed
Existing Tests: PENDING
Thanks,
Attila Magyar
Re: Review Request 60431: Cleanup relevant Kerberos identities when a
component is removed
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60431/#review178966
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On June 26, 2017, 6:23 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60431/
> -----------------------------------------------------------
>
> (Updated June 26, 2017, 6:23 p.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-21343
> https://issues.apache.org/jira/browse/AMBARI-21343
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Upon removing a component from a host, the relevant Kerberos identities should be removed as well. This includes any principals and keytab files. Care must be taken not to remove any principals or keytab files that are still in use in the cluster.
>
>
> Entry point is KerberosIdentityCleaner>>componentRemoved. It removes all of the identities of the uninstalled component, except the ones that are still used by other services/components.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e8c986b
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java d000571
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 802c93d
> ambari-server/src/main/java/org/apache/ambari/server/controller/OrderedRequestStageContainer.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 7824019
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 9755bd6
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java 2112fcc
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java ca9f013
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java 86a5e01
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java a606954
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java 0f14ca6
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java PRE-CREATION
> ambari-web/app/controllers/main/service/item.js 09c7a9c
>
>
> Diff: https://reviews.apache.org/r/60431/diff/1/
>
>
> Testing
> -------
>
> Added new unittests
> End to end tested manually:
>
> before all:
> - created a cluster with oozie
> - enabled kerberos
> 1.
> - removed oozie
> - checked if oozie_server principal and keytab was removed, and other identites weren't touched
> 2.
> - made the kdc admin credentials expired
> - removed oozie
> - supplied kdc admin credentials on the ui
> - checked if oozie_server principal and keytab was removed
> 3.
> - added oozie_server principal to a kerberos.json of an other service (so that the principal was shared)
> - removed oozie
> - checked if the oozie_server principal and keytab was NOT removed
>
>
> Existing Tests: PENDING
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 60431: Cleanup relevant Kerberos identities when a
component is removed
Posted by Attila Magyar <am...@hortonworks.com>.
> On June 27, 2017, 6:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 72 (patched)
> > <https://reviews.apache.org/r/60431/diff/5/?file=1763803#file1763803line72>
> >
> > Should probably be named `getComponentDescriptor`
Is this an Ambari convention? Under what circumstances do we like using the get prefix? I feel most of the times this doesn't add too much extra information. Yes, this method returns a value, but most of the methods return a value anyway (there are programming languages where every function returns a value), and I would rather highlight the differences instead of the similarities.
Some people like using the get prefix when the method returns a stored value instead of a calculated one. This is also debatable IMO, but here it's not the case, because these methods do calculations. And also they're private with very little scope.
> On June 27, 2017, 6:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 77 (patched)
> > <https://reviews.apache.org/r/60431/diff/5/?file=1763803#file1763803line77>
> >
> > Should be named `getIdentityNames`
See my comment above.
> On June 27, 2017, 6:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 96 (patched)
> > <https://reviews.apache.org/r/60431/diff/5/?file=1763803#file1763803line96>
> >
> > Should be named `getActiveIdentities`
See my comment above.
> On June 27, 2017, 6:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 114 (patched)
> > <https://reviews.apache.org/r/60431/diff/5/?file=1763803#file1763803line114>
> >
> > Should be named `isSameComponent`
See my comment above.
- Attila
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60431/#review179008
-----------------------------------------------------------
On June 28, 2017, 8:06 a.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60431/
> -----------------------------------------------------------
>
> (Updated June 28, 2017, 8:06 a.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-21343
> https://issues.apache.org/jira/browse/AMBARI-21343
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Upon removing a component from a host, the relevant Kerberos identities should be removed as well. This includes any principals and keytab files. Care must be taken not to remove any principals or keytab files that are still in use in the cluster.
>
>
> Entry point is KerberosIdentityCleaner>>componentRemoved. It removes all of the identities of the uninstalled component, except the ones that are still used by other services/components.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e8c986b
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java d000571
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java e4b70fd
> ambari-server/src/main/java/org/apache/ambari/server/controller/OrderedRequestStageContainer.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 7824019
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 0b845d9
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 9755bd6
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java 2112fcc
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java ca9f013
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java 86a5e01
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java a606954
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java 0f14ca6
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java PRE-CREATION
> ambari-web/app/controllers/main/service/item.js 09c7a9c
>
>
> Diff: https://reviews.apache.org/r/60431/diff/6/
>
>
> Testing
> -------
>
> Added new unittests
> End to end tested manually:
>
> before all:
> - created a cluster with oozie
> - enabled kerberos
> 1.
> - removed oozie
> - checked if oozie_server principal and keytab was removed, and other identites weren't touched
> 2.
> - made the kdc admin credentials expired
> - removed oozie
> - supplied kdc admin credentials on the ui
> - checked if oozie_server principal and keytab was removed
> 3.
> - added oozie_server principal to a kerberos.json of an other service (so that the principal was shared)
> - removed oozie
> - checked if the oozie_server principal and keytab was NOT removed
> 4.
> - disabled kerberos
> - removed oozie
> - checked that there was no identity deletion attempt
>
>
> Existing Tests:
> Results :
> Tests run: 4790, Failures: 0, Errors: 0, Skipped: 35
> Ran 244 tests in 7.122s
>
> OK
> ----------------------------------------------------------------------
> Total run:1146
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 60431: Cleanup relevant Kerberos identities when a
component is removed
Posted by Robert Levas <rl...@hortonworks.com>.
> On June 27, 2017, 2:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 72 (patched)
> > <https://reviews.apache.org/r/60431/diff/5/?file=1763803#file1763803line72>
> >
> > Should probably be named `getComponentDescriptor`
>
> Attila Magyar wrote:
> Is this an Ambari convention? Under what circumstances do we like using the get prefix? I feel most of the times this doesn't add too much extra information. Yes, this method returns a value, but most of the methods return a value anyway (there are programming languages where every function returns a value), and I would rather highlight the differences instead of the similarities.
> Some people like using the get prefix when the method returns a stored value instead of a calculated one. This is also debatable IMO, but here it's not the case, because these methods do calculations. And also they're private with very little scope.
Your argument makes sense. I will drop this.
> On June 27, 2017, 2:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 77 (patched)
> > <https://reviews.apache.org/r/60431/diff/5/?file=1763803#file1763803line77>
> >
> > Should be named `getIdentityNames`
>
> Attila Magyar wrote:
> See my comment above.
Your argument makes sense. I will drop this.
> On June 27, 2017, 2:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 96 (patched)
> > <https://reviews.apache.org/r/60431/diff/5/?file=1763803#file1763803line96>
> >
> > Should be named `getActiveIdentities`
>
> Attila Magyar wrote:
> See my comment above.
Your argument makes sense. I will drop this.
> On June 27, 2017, 2:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 114 (patched)
> > <https://reviews.apache.org/r/60431/diff/5/?file=1763803#file1763803line114>
> >
> > Should be named `isSameComponent`
>
> Attila Magyar wrote:
> See my comment above.
Your argument makes sense. I will drop this.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60431/#review179008
-----------------------------------------------------------
On June 28, 2017, 4:06 a.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60431/
> -----------------------------------------------------------
>
> (Updated June 28, 2017, 4:06 a.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-21343
> https://issues.apache.org/jira/browse/AMBARI-21343
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Upon removing a component from a host, the relevant Kerberos identities should be removed as well. This includes any principals and keytab files. Care must be taken not to remove any principals or keytab files that are still in use in the cluster.
>
>
> Entry point is KerberosIdentityCleaner>>componentRemoved. It removes all of the identities of the uninstalled component, except the ones that are still used by other services/components.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e8c986b
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java d000571
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java e4b70fd
> ambari-server/src/main/java/org/apache/ambari/server/controller/OrderedRequestStageContainer.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 7824019
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 0b845d9
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 9755bd6
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java 2112fcc
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java ca9f013
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java 86a5e01
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java a606954
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java 0f14ca6
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java PRE-CREATION
> ambari-web/app/controllers/main/service/item.js 09c7a9c
>
>
> Diff: https://reviews.apache.org/r/60431/diff/6/
>
>
> Testing
> -------
>
> Added new unittests
> End to end tested manually:
>
> before all:
> - created a cluster with oozie
> - enabled kerberos
> 1.
> - removed oozie
> - checked if oozie_server principal and keytab was removed, and other identites weren't touched
> 2.
> - made the kdc admin credentials expired
> - removed oozie
> - supplied kdc admin credentials on the ui
> - checked if oozie_server principal and keytab was removed
> 3.
> - added oozie_server principal to a kerberos.json of an other service (so that the principal was shared)
> - removed oozie
> - checked if the oozie_server principal and keytab was NOT removed
> 4.
> - disabled kerberos
> - removed oozie
> - checked that there was no identity deletion attempt
>
>
> Existing Tests:
> Results :
> Tests run: 4790, Failures: 0, Errors: 0, Skipped: 35
> Ran 244 tests in 7.122s
>
> OK
> ----------------------------------------------------------------------
> Total run:1146
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 60431: Cleanup relevant Kerberos identities when a
component is removed
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60431/#review179008
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
Lines 1 (patched)
<https://reviews.apache.org/r/60431/#comment253395>
Missing copywrite
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
Lines 35 (patched)
<https://reviews.apache.org/r/60431/#comment253393>
Javadoc
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
Lines 72 (patched)
<https://reviews.apache.org/r/60431/#comment253404>
Should probably be named `getComponentDescriptor`
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
Lines 77 (patched)
<https://reviews.apache.org/r/60431/#comment253405>
Should be named `getIdentityNames`
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
Lines 96 (patched)
<https://reviews.apache.org/r/60431/#comment253406>
Should be named `getActiveIdentities`
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
Lines 114 (patched)
<https://reviews.apache.org/r/60431/#comment253407>
Should be named `isSameComponent`
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java
Lines 37-42 (patched)
<https://reviews.apache.org/r/60431/#comment253408>
We seem to be moving towards using org.apache.commons.lang.builder.EqualsBuilder
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java
Lines 47-50 (patched)
<https://reviews.apache.org/r/60431/#comment253409>
We seem to be moving towards using org.apache.commons.lang.builder.HashCodeBuilder
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
Lines 374 (patched)
<https://reviews.apache.org/r/60431/#comment253410>
javadoc
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
Lines 383 (patched)
<https://reviews.apache.org/r/60431/#comment253411>
javadoc
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
Lines 391 (patched)
<https://reviews.apache.org/r/60431/#comment253412>
javadoc
- Robert Levas
On June 27, 2017, 8:35 a.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60431/
> -----------------------------------------------------------
>
> (Updated June 27, 2017, 8:35 a.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-21343
> https://issues.apache.org/jira/browse/AMBARI-21343
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Upon removing a component from a host, the relevant Kerberos identities should be removed as well. This includes any principals and keytab files. Care must be taken not to remove any principals or keytab files that are still in use in the cluster.
>
>
> Entry point is KerberosIdentityCleaner>>componentRemoved. It removes all of the identities of the uninstalled component, except the ones that are still used by other services/components.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e8c986b
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java d000571
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java e4b70fd
> ambari-server/src/main/java/org/apache/ambari/server/controller/OrderedRequestStageContainer.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 7824019
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 0b845d9
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 9755bd6
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java 2112fcc
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java ca9f013
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java 86a5e01
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java a606954
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java 0f14ca6
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java PRE-CREATION
> ambari-web/app/controllers/main/service/item.js 09c7a9c
>
>
> Diff: https://reviews.apache.org/r/60431/diff/5/
>
>
> Testing
> -------
>
> Added new unittests
> End to end tested manually:
>
> before all:
> - created a cluster with oozie
> - enabled kerberos
> 1.
> - removed oozie
> - checked if oozie_server principal and keytab was removed, and other identites weren't touched
> 2.
> - made the kdc admin credentials expired
> - removed oozie
> - supplied kdc admin credentials on the ui
> - checked if oozie_server principal and keytab was removed
> 3.
> - added oozie_server principal to a kerberos.json of an other service (so that the principal was shared)
> - removed oozie
> - checked if the oozie_server principal and keytab was NOT removed
> 4.
> - disabled kerberos
> - removed oozie
> - checked that there was no identity deletion attempt
>
>
> Existing Tests:
> Results :
> Tests run: 4790, Failures: 0, Errors: 0, Skipped: 35
> Ran 244 tests in 7.122s
>
> OK
> ----------------------------------------------------------------------
> Total run:1146
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 60431: Cleanup relevant Kerberos identities when a
component is removed
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60431/
-----------------------------------------------------------
(Updated June 28, 2017, 8:06 a.m.)
Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Laszlo Puskas, Robert Levas, and Sebastian Toader.
Changes
-------
added missing copyrights and javadocs
Bugs: AMBARI-21343
https://issues.apache.org/jira/browse/AMBARI-21343
Repository: ambari
Description
-------
Upon removing a component from a host, the relevant Kerberos identities should be removed as well. This includes any principals and keytab files. Care must be taken not to remove any principals or keytab files that are still in use in the cluster.
Entry point is KerberosIdentityCleaner>>componentRemoved. It removes all of the identities of the uninstalled component, except the ones that are still used by other services/components.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e8c986b
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java d000571
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java e4b70fd
ambari-server/src/main/java/org/apache/ambari/server/controller/OrderedRequestStageContainer.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 7824019
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 0b845d9
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 9755bd6
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java 2112fcc
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java ca9f013
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java 86a5e01
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java a606954
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java 0f14ca6
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java PRE-CREATION
ambari-web/app/controllers/main/service/item.js 09c7a9c
Diff: https://reviews.apache.org/r/60431/diff/6/
Changes: https://reviews.apache.org/r/60431/diff/5-6/
Testing
-------
Added new unittests
End to end tested manually:
before all:
- created a cluster with oozie
- enabled kerberos
1.
- removed oozie
- checked if oozie_server principal and keytab was removed, and other identites weren't touched
2.
- made the kdc admin credentials expired
- removed oozie
- supplied kdc admin credentials on the ui
- checked if oozie_server principal and keytab was removed
3.
- added oozie_server principal to a kerberos.json of an other service (so that the principal was shared)
- removed oozie
- checked if the oozie_server principal and keytab was NOT removed
4.
- disabled kerberos
- removed oozie
- checked that there was no identity deletion attempt
Existing Tests:
Results :
Tests run: 4790, Failures: 0, Errors: 0, Skipped: 35
Ran 244 tests in 7.122s
OK
----------------------------------------------------------------------
Total run:1146
Total errors:0
Total failures:0
OK
Thanks,
Attila Magyar
Re: Review Request 60431: Cleanup relevant Kerberos identities when a
component is removed
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60431/
-----------------------------------------------------------
(Updated June 27, 2017, 12:35 p.m.)
Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Laszlo Puskas, Robert Levas, and Sebastian Toader.
Changes
-------
don not try to update the owner and group of keytab files in finalize step
Bugs: AMBARI-21343
https://issues.apache.org/jira/browse/AMBARI-21343
Repository: ambari
Description
-------
Upon removing a component from a host, the relevant Kerberos identities should be removed as well. This includes any principals and keytab files. Care must be taken not to remove any principals or keytab files that are still in use in the cluster.
Entry point is KerberosIdentityCleaner>>componentRemoved. It removes all of the identities of the uninstalled component, except the ones that are still used by other services/components.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e8c986b
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java d000571
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java e4b70fd
ambari-server/src/main/java/org/apache/ambari/server/controller/OrderedRequestStageContainer.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 7824019
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 0b845d9
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 9755bd6
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java 2112fcc
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java ca9f013
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java 86a5e01
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java a606954
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java 0f14ca6
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java PRE-CREATION
ambari-web/app/controllers/main/service/item.js 09c7a9c
Diff: https://reviews.apache.org/r/60431/diff/3/
Changes: https://reviews.apache.org/r/60431/diff/2-3/
Testing
-------
Added new unittests
End to end tested manually:
before all:
- created a cluster with oozie
- enabled kerberos
1.
- removed oozie
- checked if oozie_server principal and keytab was removed, and other identites weren't touched
2.
- made the kdc admin credentials expired
- removed oozie
- supplied kdc admin credentials on the ui
- checked if oozie_server principal and keytab was removed
3.
- added oozie_server principal to a kerberos.json of an other service (so that the principal was shared)
- removed oozie
- checked if the oozie_server principal and keytab was NOT removed
4.
- disabled kerberos
- removed oozie
- checked that there was no identity deletion attempt
Existing Tests: PENDING
Thanks,
Attila Magyar
Re: Review Request 60431: Cleanup relevant Kerberos identities when a
component is removed
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60431/
-----------------------------------------------------------
(Updated June 27, 2017, 11:20 a.m.)
Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Laszlo Puskas, Robert Levas, and Sebastian Toader.
Changes
-------
- added guard clause for testing the security type of the cluster
Bugs: AMBARI-21343
https://issues.apache.org/jira/browse/AMBARI-21343
Repository: ambari
Description
-------
Upon removing a component from a host, the relevant Kerberos identities should be removed as well. This includes any principals and keytab files. Care must be taken not to remove any principals or keytab files that are still in use in the cluster.
Entry point is KerberosIdentityCleaner>>componentRemoved. It removes all of the identities of the uninstalled component, except the ones that are still used by other services/components.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e8c986b
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java d000571
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java e4b70fd
ambari-server/src/main/java/org/apache/ambari/server/controller/OrderedRequestStageContainer.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 7824019
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 9755bd6
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java 2112fcc
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java ca9f013
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java 86a5e01
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java a606954
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java 0f14ca6
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java PRE-CREATION
ambari-web/app/controllers/main/service/item.js 09c7a9c
Diff: https://reviews.apache.org/r/60431/diff/2/
Changes: https://reviews.apache.org/r/60431/diff/1-2/
Testing (updated)
-------
Added new unittests
End to end tested manually:
before all:
- created a cluster with oozie
- enabled kerberos
1.
- removed oozie
- checked if oozie_server principal and keytab was removed, and other identites weren't touched
2.
- made the kdc admin credentials expired
- removed oozie
- supplied kdc admin credentials on the ui
- checked if oozie_server principal and keytab was removed
3.
- added oozie_server principal to a kerberos.json of an other service (so that the principal was shared)
- removed oozie
- checked if the oozie_server principal and keytab was NOT removed
4.
- disabled kerberos
- removed oozie
- checked that there was no identity deletion attempt
Existing Tests: PENDING
Thanks,
Attila Magyar