You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/11/20 20:42:00 UTC
[jira] [Commented] (GEODE-6073) Spotless Check should not fail on
Windows
[ https://issues.apache.org/jira/browse/GEODE-6073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693767#comment-16693767 ]
ASF subversion and git services commented on GEODE-6073:
--------------------------------------------------------
Commit be99d7be0dd92159fc69856b8d26a046c3989e37 in geode's branch refs/heads/develop from M. Oleske
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=be99d7b ]
GEODE-6073: All files have lf endings (#2873)
- Spotless no longer uses line endings check as it is not recommened
- https://github.com/diffplug/spotless/tree/master/plugin-gradle#line-endings-and-encodings-invisible-stuff
> Spotless Check should not fail on Windows
> -----------------------------------------
>
> Key: GEODE-6073
> URL: https://issues.apache.org/jira/browse/GEODE-6073
> Project: Geode
> Issue Type: Task
> Components: build
> Reporter: Michael Oleske
> Assignee: Michael Oleske
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> _As a_ Engineer building on Windows
> _I want_ spotless to pass
> _So that_ I feel confident in changes I'm going to make
> *Given* I have freshly cloned Geode
> *When* I run {{.\gradlew.bat build}}
> *Then* I see a successful build with no Spotless errors
> Notes: This was based on the following conversation in the [dev list|https://markmail.org/message/2jippxjsl6a6r6ae]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)