You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jordan West (Jira)" <ji...@apache.org> on 2020/05/12 19:28:00 UTC
[jira] [Comment Edited] (CASSANDRA-15533) Don't allocate unneeded
MergeIterator in OnDiskToken#iterator
[ https://issues.apache.org/jira/browse/CASSANDRA-15533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105687#comment-17105687 ]
Jordan West edited comment on CASSANDRA-15533 at 5/12/20, 7:27 PM:
-------------------------------------------------------------------
Since CASSANDRA-15392 is not merged and this has existed for a while my preference would be to wait until the subsequent release. The improvement is minor if 15392 isn't merged and if it is merged only affects the changes if SASI is enabled.
was (Author: jrwest):
Since CASSANDRA-15392 is merged and this has existed for a while my preference would be to wait until the subsequent release. The improvement is minor if 15392 isn't merged and if it is merged only affects the changes if SASI is enabled.
> Don't allocate unneeded MergeIterator in OnDiskToken#iterator
> --------------------------------------------------------------
>
> Key: CASSANDRA-15533
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15533
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SASI
> Reporter: Jordan West
> Assignee: Jordan West
> Priority: Normal
> Fix For: 4.0, 4.0-rc
>
>
> When reviewing CASSANDRA-15392 it became apparent that the MergeIterator allocated by OnDiskToken#iterator is rarely necessary and so we should avoid allocating one when not needed and skip the MergeIterator pool when needed because its unlikely to be sized correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org