[GitHub] [iceberg] rdblue commented on a diff in pull request #7778: Python: Add support for sequence number inheritance

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #7778:
URL: https://github.com/apache/iceberg/pull/7778#discussion_r1219844965


##########
python/pyiceberg/manifest.py:
##########
@@ -266,11 +267,25 @@ def __init__(self, *data: Any, **named_data: Any) -> None:
 
     def fetch_manifest_entry(self, io: FileIO) -> List[ManifestEntry]:
         file = io.new_input(self.manifest_path)
-        return list(read_manifest_entry(file))
+        return [_inherit_sequence_number(entry, self) for entry in read_manifest_entry(file)]

Review Comment:
   Why not do this in `read_manifest_entry`? I think it would make sense to pass the sequence number into that method so that there isn't a way for people to read without sequence numbers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org