[GitHub] ashb commented on a change in pull request #4396: [WIP][AIRFLOW-3585] - Add edges to database

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #4396: [WIP][AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#discussion_r250183222
 
 

 ##########
 File path: airflow/models/__init__.py
 ##########
 @@ -703,6 +644,57 @@ def __init__(self, task, execution_date, state=None):
         # Not persisted to the database so only valid for the current process
         self.raw = False
 
+    @staticmethod
+    @provide_session
+    def clear_task_instances(tis,
+                             activate_dag_runs=True,
+                             dag=None,
+                             session=None
+                             ):
+        """
+        Clears a set of task instances, but makes sure the running ones
+        get killed.
+
+        :param tis: a list of task instances
+        :param session: current session
+        :param activate_dag_runs: flag to check for active dag run
+        :param dag: DAG object
+        """
+        job_ids = []
 
 Review comment:
   ```
   >>> type({})
   <class 'dict'>
   ```
   
   empty vs with something in it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services