You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Brian Fox (JIRA)" <ji...@codehaus.org> on 2008/03/06 04:06:28 UTC

[jira] Updated: (MNG-2583) DefaultArtifact: Method getVersionRange returns null also if field version is already set! [SMALL PATCH ATTACHED]

     [ http://jira.codehaus.org/browse/MNG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Fox updated MNG-2583:
---------------------------

    Fix Version/s:     (was: Reviewed Pending Version Assignment)
                   2.0.10

I suspect this is already fixed. Can you reproduce?

> DefaultArtifact: Method getVersionRange returns null also if field version is already set! [SMALL PATCH ATTACHED]
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: MNG-2583
>                 URL: http://jira.codehaus.org/browse/MNG-2583
>             Project: Maven 2
>          Issue Type: Improvement
>          Components: Artifacts and Repositories
>    Affects Versions: 2.0-alpha-1
>         Environment: Java5, WinXp
>            Reporter: Martin Zeltner
>            Assignee: Jason van Zyl
>             Fix For: 2.0.10
>
>         Attachments: patch_maven-artifact_made-getVersionRange-saver.patch
>
>
> In class *org.apache.maven.artifact.DefaultArtifact* method *getVersionRange* returns *null* altough the version field is already set. In attached patch I check in method getVersionRange if versionRange is null if field version or baseVersion is already set and then create the versionRange by using version/baseVersion. By the way I've replaced HashMap with a LinkedHashMap to remember the insertion order of meta data.
> For those who don't see why this patch is needed can try binding the eclipse plugin to a phase before the jar plugin is bound. The eclipse plugin uses the org.apache.maven.artifact.resolver.DefaultArtifactCollector which is invoking method setVersion of org.apache.maven.artifact.DefaultArtifact which will erase field version range and cause a NullPointerException in plugin jar that doesn't check if returned version range is null.
> Cheers,
> Martin

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira