You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "heliang666s (via GitHub)" <gi...@apache.org> on 2024/04/17 07:15:10 UTC

[PR] change the null reference to empty object in UrlMappingPattern.java (eventmesh)

heliang666s opened a new pull request, #4846:
URL: https://github.com/apache/eventmesh/pull/4846

   ### Motivation
   change the null reference to empty object in UrlMappingPattern.java    issue#4136
   ### Modifications
   change return null to a empty map
   ### Documentation
   No
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   - If a feature is not applicable for documentation, explain why?
   - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

Re: [PR] [ISSUE #4136] change the null reference to empty object in UrlMappingPattern.java (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4846:
URL: https://github.com/apache/eventmesh/pull/4846#issuecomment-2158176436

   Hi @heliang666s , the `eventmesh-admin-rocketmq` module referenced in this issue has been removed in https://github.com/apache/eventmesh/pull/4490 (merged on 2023-10-17). Do you have any additional information to share? Feel free to share your latest insights with us. If you feel that this issue has been resolved, you are welcome to close it. We sincerely appreciate your contributions to Apache EventMesh and you can pick another Good First Issue to start your first step.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #4136] change the null reference to empty object in UrlMappingPattern.java (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia closed pull request #4846: [ISSUE #4136] change the null reference to empty object in UrlMappingPattern.java
URL: https://github.com/apache/eventmesh/pull/4846


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

Re: [PR] [ISSUE #4136] change the null reference to empty object in UrlMappingPattern.java (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4846:
URL: https://github.com/apache/eventmesh/pull/4846#issuecomment-3123787921

   Considering the lack of activity, this pull request will now be closed as stale. Thank you for your contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] change the null reference to empty object in UrlMappingPattern.java (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4846:
URL: https://github.com/apache/eventmesh/pull/4846#issuecomment-2061483812

   @heliang666s The target branch you merge this PR into should be `master` instead of `develop`. By then you should be able to pass CI.
   
   Developing with a branch that corresponds to a single issue minimizes the chance that you'll run into any Git difficulties.
   
   By the way, kindly refer to the standard title format used in other PRs.
   
   @mxsm How about delete this outdated `develop` branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #4136] change the null reference to empty object in UrlMappingPattern.java (eventmesh)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4846:
URL: https://github.com/apache/eventmesh/pull/4846#issuecomment-2802604809

   It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.
   
   If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] change the null reference to empty object in UrlMappingPattern.java (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4846:
URL: https://github.com/apache/eventmesh/pull/4846#issuecomment-2061505413

   @heliang666s Please resolve conflicts.
   
   @mxsm The `The base branch was changed.` comment was a automatic message sent by GitHub.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #4136] change the null reference to empty object in UrlMappingPattern.java (eventmesh)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4846:
URL: https://github.com/apache/eventmesh/pull/4846#issuecomment-2282849315

   It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.
   
   If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org