[GitHub] mistercrunch commented on a change in pull request #6363: [bugfix] deck.gl grid&hex don't respond to zoom&drag

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #6363: [bugfix] deck.gl grid&hex don't respond to zoom&drag
URL: https://github.com/apache/incubator-superset/pull/6363#discussion_r233980330
 
 

 ##########
 File path: superset/assets/src/visualizations/deckgl/DeckGLContainer.jsx
 ##########
 @@ -23,12 +24,13 @@ const defaultProps = {
 export default class DeckGLContainer extends React.Component {
   constructor(props) {
     super(props);
+    this.tick = this.tick.bind(this);
+    this.onViewportChange = this.onViewportChange.bind(this);
 
 Review comment:
   We should introduce `autobind` all at once, would rather not have it only in some places.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org