You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "autophagy (via GitHub)" <gi...@apache.org> on 2026/03/12 10:23:03 UTC
[PR] [BP-2.2][FLINK-39242][python] Fix error when getting columns from ResolvedSchema [flink]
autophagy opened a new pull request, #27761:
URL: https://github.com/apache/flink/pull/27761
Backport of 74a3243984d23a19d1e6ac77c86d1a6c477da584.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BP-2.2][FLINK-39242][python] Fix error when getting columns from ResolvedSchema [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #27761:
URL: https://github.com/apache/flink/pull/27761#discussion_r2923784086
##########
flink-python/pyflink/table/tests/test_schema_operation.py:
##########
@@ -42,7 +42,23 @@ def test_get_resolved_schema(self):
['a', 'b', 'c'],
[DataTypes.BIGINT(), DataTypes.STRING(), DataTypes.STRING()],
)
- assert resolved_schema == expected_schema
+ self.assertEqual(resolved_schema, expected_schema)
+
+ def test_resolved_schema_get_columns(self):
+ physical_schema = ResolvedSchema.physical(
Review Comment:
I realise this is a port - but it worth be worth testing the computed and metadata cases as well I think. Unelss they are already covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BP-2.2][FLINK-39242][python] Fix error when getting columns from ResolvedSchema [flink]
Posted by "autophagy (via GitHub)" <gi...@apache.org>.
autophagy commented on code in PR #27761:
URL: https://github.com/apache/flink/pull/27761#discussion_r2923863503
##########
flink-python/pyflink/table/tests/test_schema_operation.py:
##########
@@ -42,7 +42,23 @@ def test_get_resolved_schema(self):
['a', 'b', 'c'],
[DataTypes.BIGINT(), DataTypes.STRING(), DataTypes.STRING()],
)
- assert resolved_schema == expected_schema
+ self.assertEqual(resolved_schema, expected_schema)
+
+ def test_resolved_schema_get_columns(self):
+ physical_schema = ResolvedSchema.physical(
Review Comment:
Good point - i'll open a follow up PR against master for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BP-2.2][FLINK-39242][python] Fix error when getting columns from ResolvedSchema [flink]
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr merged PR #27761:
URL: https://github.com/apache/flink/pull/27761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BP-2.2][FLINK-39242][python] Fix error when getting columns from ResolvedSchema [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27761:
URL: https://github.com/apache/flink/pull/27761#issuecomment-4045640721
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "369f097d418469585b47bdd45f7d6b1eea6601cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "369f097d418469585b47bdd45f7d6b1eea6601cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 369f097d418469585b47bdd45f7d6b1eea6601cc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org