You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/12 09:09:12 UTC

[GitHub] [flink] tillrohrmann commented on pull request #17777: [FLINK-24886][core] TimeUtils supports the form of m.

tillrohrmann commented on pull request #17777:
URL: https://github.com/apache/flink/pull/17777#issuecomment-1010814744


   > > hi @Thesharing , orignial commits are 4, i just reset the first commit and rebase code, then ci is running and you can see the log
   > 
   > Thank you for rebasing the code. I've checked the failed test cases. If we make sure the order of minute units stay the same , the broken tests will pass.
   > 
   > Would you mind change the line
   > 
   > ```
   > MINUTES(ChronoUnit.MINUTES, singular("m"), singular("min"), plural("minute"))
   > ```
   > 
   > into
   > 
   > ```
   > MINUTES(ChronoUnit.MINUTES, singular("min"), singular("m"), plural("minute"))
   > ```
   > 
   > and run the CI again?
   
   Why is the order of units important?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org