You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bugraoz93 (via GitHub)" <gi...@apache.org> on 2025/05/07 18:26:23 UTC
[PR] fix(snowflake): infinite loop via moving the _get_conn_params call to drive class [airflow]
bugraoz93 opened a new pull request, #50319:
URL: https://github.com/apache/airflow/pull/50319
Moved the `_get_conn_params` call to the drive class (`SnowflakeSqlApiHook`) since it was there in the first place. Now `SnowflakeSqlApiHook` is calling the `_get_conn_params`, but it is `_get_conn_params` calls from `super()._get_conn_params` again, so it shouldn't do any infinite loops. The original method was added without None in the conn_config parameter, so converting that back since it isn't needed and is backwards compatible.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(snowflake): infinite loop via moving the _get_conn_params call to drive class [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #50319:
URL: https://github.com/apache/airflow/pull/50319#issuecomment-2862554103
> Hi @bugraoz93 , this still does not fix the infinite loop issue. The property "self._get_conn_params" is first called from get_conn(). The function inturn calls the get_oauth_token. The first line of the get_oauth_token is referring to the property "self.account_identifier" to construct the url which inturn calls the self._get_conn_params. SInce the property "self._get_conn_params" hasn't completed executing and therefore not caches, it goes on an infinite loop.
>
> The infinite loop is caused by calling "self.account_identifier" in the get_oauth_token function.
> I've raised a PR with the fix, https://github.com/apache/airflow/pull/50344
Okay, my assumption was we are calling get_conn_params, and that is calling the same method get_oauth_token recursively. I missed the account identifier also calling that, nice one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(snowflake): infinite loop via moving the _get_conn_params call to drive class [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #50319:
URL: https://github.com/apache/airflow/pull/50319#issuecomment-2859811627
cc: @Sharashchandra, if you have time and can test too, that would be amazing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(snowflake): infinite loop via moving the _get_conn_params call to drive class [airflow]
Posted by "Sharashchandra (via GitHub)" <gi...@apache.org>.
Sharashchandra commented on PR #50319:
URL: https://github.com/apache/airflow/pull/50319#issuecomment-2862477087
Hi @bugraoz93 , this still does not fix the infinite loop issue. The property "self._get_conn_params" is first called from get_conn(). The function inturn calls the get_oauth_token. The first line of the get_oauth_token is referring to the property "self.account_identifier" to construct the url which inturn calls the self._get_conn_params. SInce the property "self._get_conn_params" hasn't completed executing and therefore not caches, it goes on an infinite loop.
The infinite loop is caused by calling "self.account_identifier" in the get_oauth_token function. Let me know and I can raise a PR for the fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(snowflake): infinite loop via moving the _get_conn_params call to drive class [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 closed pull request #50319: fix(snowflake): infinite loop via moving the _get_conn_params call to drive class
URL: https://github.com/apache/airflow/pull/50319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(snowflake): infinite loop via moving the _get_conn_params call to drive class [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #50319:
URL: https://github.com/apache/airflow/pull/50319#issuecomment-2859954213
CI is unrelated
```bash
gremlin: ..................................................ERROR: Maximum number of retries while checking service. Exiting
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(snowflake): infinite loop via moving the _get_conn_params call to drive class [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #50319:
URL: https://github.com/apache/airflow/pull/50319#issuecomment-2859811319
cc: @eladkal @gopidesupavan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(snowflake): infinite loop via moving the _get_conn_params call to drive class [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #50319:
URL: https://github.com/apache/airflow/pull/50319#issuecomment-2862562512
Closed in favor of #50344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org