[jira] [Commented] (FLINK-15471) HA e2e check for empty .out files does not print specific error

["Yun Tang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008074#comment-17008074 ] 

Yun Tang commented on FLINK-15471:
----------------------------------

If there really exist non empty out files, I think {{check_logs_for_non_empty_out_files}} would already print the error cause with message of "FAILURE: Alerts found at the general purpose job.". Did I miss something for the scenario of "not actually print the error cause"?

> HA e2e check for empty .out files does not print specific error
> ---------------------------------------------------------------
>
>                 Key: FLINK-15471
>                 URL: https://issues.apache.org/jira/browse/FLINK-15471
>             Project: Flink
>          Issue Type: Improvement
>          Components: Test Infrastructure
>    Affects Versions: 1.9.0
>            Reporter: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.9.2, 1.10.0
>
>
> {{common_ha.sh#verify_logs:}}
> {code}
>     if ! check_logs_for_non_empty_out_files; then
>         echo "FAILURE: Alerts found at the general purpose job."
>         EXIT_CODE=1
>     fi
> {code}
> Since check_logs_for_non_empty_out_files does only set EXIT_CODE without modifying the return value the check will never fail.
> While the test will still fail (since EXIT_CODE is later being evaluated), we may not actually print the error cause.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)