You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ashb (via GitHub)" <gi...@apache.org> on 2026/04/22 16:14:58 UTC
[PR] Keep DualStatsManager as a try/except import as it is soon going to be removed [airflow]
ashb opened a new pull request, #65676:
URL: https://github.com/apache/airflow/pull/65676
We are actively working on removing the DualStats manager in #63932, as other than uses cases like this introduced in #65472 it is not publicly used, so by keeping it as a try/except it means we are free to remove it at our whim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Keep DualStatsManager as a try/except import as it is soon going to be removed [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 merged PR #65676:
URL: https://github.com/apache/airflow/pull/65676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Keep DualStatsManager as a try/except import as it is soon going to be removed [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #65676:
URL: https://github.com/apache/airflow/pull/65676#discussion_r3125525300
##########
providers/edge3/src/airflow/providers/edge3/models/edge_worker.py:
##########
@@ -25,10 +25,13 @@
from sqlalchemy import JSON, Integer, String, delete, select
from sqlalchemy.orm import Mapped
+try:
+ from airflow.sdk.observability.stats import DualStatsManager
+except ImportError:
+ DualStatsManager = None # type: ignore[assignment,misc] # Airflow < 3.2 compat
Review Comment:
Can this be moved down after other imports please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Keep DualStatsManager as a try/except import as it is soon going to be removed [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #65676:
URL: https://github.com/apache/airflow/pull/65676#discussion_r3125621273
##########
providers/edge3/src/airflow/providers/edge3/models/edge_worker.py:
##########
@@ -25,10 +25,13 @@
from sqlalchemy import JSON, Integer, String, delete, select
from sqlalchemy.orm import Mapped
+try:
+ from airflow.sdk.observability.stats import DualStatsManager
+except ImportError:
+ DualStatsManager = None # type: ignore[assignment,misc] # Airflow < 3.2 compat
Review Comment:
Sure. This was how it was pre-change so I just copied that.
Will move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Keep DualStatsManager as a try/except import as it is soon going to be removed [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #65676:
URL: https://github.com/apache/airflow/pull/65676#issuecomment-4299549019
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Keep DualStatsManager as a try/except import as it is soon going to be removed [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #65676:
URL: https://github.com/apache/airflow/pull/65676#issuecomment-4300006936
Thanks for fixing prior providers-wave, with this we have no direct version dependency and remove DualStans manager. Did not notice that Edge3 was not released (yet).
(plus congrats for your first PR 8-) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org