[GitHub] [airflow] Bisk1 commented on a diff in pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state

["Bisk1 (via GitHub)" <gi...@apache.org>]

Bisk1 commented on code in PR #33893:
URL: https://github.com/apache/airflow/pull/33893#discussion_r1309061275


##########
docs/apache-airflow/core-concepts/tasks.rst:
##########
@@ -76,7 +76,6 @@ The possible states for a Task Instance are:
 * ``queued``: The task has been assigned to an Executor and is awaiting a worker
 * ``running``: The task is running on a worker (or on a local/synchronous executor)
 * ``success``: The task finished running without errors
-* ``shutdown``: The task was externally requested to shut down when it was running

Review Comment:
   I felt like it's not useful information for the typical audience of the docs because the docs are meant for specific Airflow version and if someone has older version they should look at relevant, older docs. There probably should be an in release notes though. But I can modify it if you're sure.



##########
docs/apache-airflow/core-concepts/tasks.rst:
##########
@@ -76,7 +76,6 @@ The possible states for a Task Instance are:
 * ``queued``: The task has been assigned to an Executor and is awaiting a worker
 * ``running``: The task is running on a worker (or on a local/synchronous executor)
 * ``success``: The task finished running without errors
-* ``shutdown``: The task was externally requested to shut down when it was running

Review Comment:
   I felt like it's not useful information for the typical audience of the docs because the docs are meant for specific Airflow version and if someone has older version they should look at relevant, older docs. Probably should show in release notes. But I can modify it if you're sure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org