[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4143: Deprecate /hwinfo

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #4143: Deprecate /hwinfo
URL: https://github.com/apache/trafficcontrol/pull/4143#discussion_r351024735
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/api/shared_handlers_test.go
 ##########
 @@ -142,7 +142,7 @@ func TestCreateHandler(t *testing.T) {
 	createFunc(w, r)
 
 	//verifies the body is in the expected format
-	body := `{"alerts":[{"text":"tester was created.","level":"success"}],"response":{"ID":1}}`
+	body := "{\"alerts\":[{\"text\":\"tester was created.\",\"level\":\"success\"}],\"response\":{\"ID\":1}}\n"
 
 Review comment:
   This might be easier to read if you keep the backticks and instead just add `+"\n"` to the end. Does that work?
   
   Same for the two lines below as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services