You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2015/09/10 00:46:51 UTC
Re: Review Request 36125: Removing '.json' extension in master
endpoints url
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36125/#review98275
-----------------------------------------------------------
Ship it!
Looks great! I'm not sure if we needed to change all the internal references to remove .json, since we're keeping that endpoint for compatibility, but it's good that we're testing the new endpoint.
Did you test to verify that the `.json` endpoints still work?
src/master/master.cpp (lines 782 - 783)
<https://reviews.apache.org/r/36125/#comment154615>
s/at the end of the deprecation cycle/after Mesos 0.25 has been released/ (or whatever release this patch lands in)
Ditto elsewhere
Probably a good idea to file a new JIRA to remove the deprecated endpoints, and target it to 0.26
src/tests/master_tests.cpp (lines 3247 - 3248)
<https://reviews.apache.org/r/36125/#comment154617>
Comments wrap at 70 characters.
Also, s/from master/from the master's/
src/tests/master_tests.cpp (line 3385)
<https://reviews.apache.org/r/36125/#comment154618>
s/in master/in the master's/
- Adam B
On Sept. 9, 2015, 12:58 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36125/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 12:58 p.m.)
>
>
> Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-2719
> https://issues.apache.org/jira/browse/MESOS-2719
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Removing json extension for HTTP endpoints in master
>
>
> Diffs
> -----
>
> src/cli/mesos-cat 73dc63e
> src/cli/mesos-ps ee14d51
> src/cli/mesos-scp 77b8557
> src/cli/mesos-tail 256a804
> src/master/constants.hpp c3fe140
> src/master/http.cpp 37d76ee
> src/master/master.hpp 0432842
> src/master/master.cpp 95207d2
> src/tests/fault_tolerance_tests.cpp 89cb18b
> src/tests/master_tests.cpp 8a6b98b
> src/webui/master/static/js/controllers.js 3445028
>
> Diff: https://reviews.apache.org/r/36125/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 36125: Removing '.json' extension in master
endpoints url
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
> On Sept. 9, 2015, 10:46 p.m., Adam B wrote:
> > Looks great! I'm not sure if we needed to change all the internal references to remove .json, since we're keeping that endpoint for compatibility, but it's good that we're testing the new endpoint.
> >
> > Did you test to verify that the `.json` endpoints still work?
Yes I tried the .json endpoints
- Isabel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36125/#review98275
-----------------------------------------------------------
On Sept. 10, 2015, 5:33 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36125/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 5:33 p.m.)
>
>
> Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-2719
> https://issues.apache.org/jira/browse/MESOS-2719
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Removing json extension for HTTP endpoints in master
>
>
> Diffs
> -----
>
> src/cli/mesos-cat 73dc63e
> src/cli/mesos-ps ee14d51
> src/cli/mesos-scp 77b8557
> src/cli/mesos-tail 256a804
> src/master/constants.hpp c3fe140
> src/master/http.cpp a052e55
> src/master/master.hpp 1dfc947
> src/master/master.cpp 4b60e63
> src/tests/fault_tolerance_tests.cpp 89cb18b
> src/tests/master_tests.cpp 8a6b98b
> src/webui/master/static/js/controllers.js 3445028
>
> Diff: https://reviews.apache.org/r/36125/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>