You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saksham Srivastava <sa...@citrix.com> on 2013/08/14 13:57:51 UTC

Review Request 13560: CLOUDSTACK-4021 : Update the test test_explicit_dedication.py according to new changes to dedicated resources

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13560/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Prachi Damle.


Bugs: CLOUDSTACK-4021


Repository: cloudstack-git


Description
-------

test_explicit_dedication.py need to modified according to the new changes to dedicate resources feature.
Now dedicate a host first and use the created affinity group to deploy vm.


Diffs
-----

  test/integration/component/test_explicit_dedication.py bd97551 
  tools/marvin/marvin/integration/lib/common.py 4f5acef 

Diff: https://reviews.apache.org/r/13560/diff/


Testing
-------

test runs successfully whenever an empty host is found.


Thanks,

Saksham Srivastava


Re: Review Request 13560: CLOUDSTACK-4021 : Update the test test_explicit_dedication.py according to new changes to dedicated resources

Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13560/#review25133
-----------------------------------------------------------


Review 13560 PASSED the build test
The url of build cloudstack-master-with-patch #132 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/132/

- Jenkins Cloudstack.org


On Aug. 14, 2013, 11:57 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13560/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 11:57 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Prachi Damle.
> 
> 
> Bugs: CLOUDSTACK-4021
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> test_explicit_dedication.py need to modified according to the new changes to dedicate resources feature.
> Now dedicate a host first and use the created affinity group to deploy vm.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_explicit_dedication.py bd97551 
>   tools/marvin/marvin/integration/lib/common.py 4f5acef 
> 
> Diff: https://reviews.apache.org/r/13560/diff/
> 
> 
> Testing
> -------
> 
> test runs successfully whenever an empty host is found.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Re: Review Request 13560: CLOUDSTACK-4021 : Update the test test_explicit_dedication.py according to new changes to dedicated resources

Posted by Saksham Srivastava <sa...@citrix.com>.

> On Dec. 1, 2014, 3:33 a.m., Pierre-Luc Dion wrote:
> > Is this still valid? could it be possible to resubmit a new patch from master that remove conflict? 
> > 
> > thanks

Yes this is still valid.
https://reviews.apache.org/r/29201/diff/ will address the issue.
Closing the current review request.


- Saksham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13560/#review63331
-----------------------------------------------------------


On Jan. 17, 2014, 11:06 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13560/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 11:06 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Girish Shilamkar, Prachi Damle, and Rayees Namathponnan.
> 
> 
> Bugs: CLOUDSTACK-4021
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4021
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> test_explicit_dedication.py need to modified according to the new changes to dedicate resources feature.
> Now dedicate a host first and use the created affinity group to deploy vm.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_explicit_dedication.py 7aefc21 
>   tools/marvin/marvin/integration/lib/common.py 550de1a 
> 
> Diff: https://reviews.apache.org/r/13560/diff/
> 
> 
> Testing
> -------
> 
> test runs successfully whenever an empty host is found.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Re: Review Request 13560: CLOUDSTACK-4021 : Update the test test_explicit_dedication.py according to new changes to dedicated resources

Posted by Pierre-Luc Dion <pd...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13560/#review63331
-----------------------------------------------------------


Is this still valid? could it be possible to resubmit a new patch from master that remove conflict? 

thanks

- Pierre-Luc Dion


On Jan. 17, 2014, 11:06 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13560/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 11:06 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Girish Shilamkar, Prachi Damle, and Rayees Namathponnan.
> 
> 
> Bugs: CLOUDSTACK-4021
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4021
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> test_explicit_dedication.py need to modified according to the new changes to dedicate resources feature.
> Now dedicate a host first and use the created affinity group to deploy vm.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_explicit_dedication.py 7aefc21 
>   tools/marvin/marvin/integration/lib/common.py 550de1a 
> 
> Diff: https://reviews.apache.org/r/13560/diff/
> 
> 
> Testing
> -------
> 
> test runs successfully whenever an empty host is found.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Re: Review Request 13560: CLOUDSTACK-4021 : Update the test test_explicit_dedication.py according to new changes to dedicated resources

Posted by Saksham Srivastava <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13560/
-----------------------------------------------------------

(Updated Jan. 17, 2014, 11:06 a.m.)


Review request for cloudstack, Devdeep Singh, Girish Shilamkar, Prachi Damle, and Rayees Namathponnan.


Changes
-------

Resubmitting an old patch by removing merge conflicts.


Bugs: CLOUDSTACK-4021
    https://issues.apache.org/jira/browse/CLOUDSTACK-4021


Repository: cloudstack-git


Description
-------

test_explicit_dedication.py need to modified according to the new changes to dedicate resources feature.
Now dedicate a host first and use the created affinity group to deploy vm.


Diffs (updated)
-----

  test/integration/component/test_explicit_dedication.py 7aefc21 
  tools/marvin/marvin/integration/lib/common.py 550de1a 

Diff: https://reviews.apache.org/r/13560/diff/


Testing
-------

test runs successfully whenever an empty host is found.


Thanks,

Saksham Srivastava


Re: Review Request 13560: CLOUDSTACK-4021 : Update the test test_explicit_dedication.py according to new changes to dedicated resources

Posted by Saksham Srivastava <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13560/
-----------------------------------------------------------

(Updated Aug. 22, 2013, 10:27 a.m.)


Review request for cloudstack, Devdeep Singh and Prachi Damle.


Bugs: CLOUDSTACK-4021


Repository: cloudstack-git


Description
-------

test_explicit_dedication.py need to modified according to the new changes to dedicate resources feature.
Now dedicate a host first and use the created affinity group to deploy vm.


Diffs
-----

  test/integration/component/test_explicit_dedication.py bd97551 
  tools/marvin/marvin/integration/lib/common.py 4f5acef 

Diff: https://reviews.apache.org/r/13560/diff/


Testing
-------

test runs successfully whenever an empty host is found.


Thanks,

Saksham Srivastava