You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/11/10 11:31:45 UTC
[GitHub] [incubator-ratis] runzhiwang opened a new pull request #266: RATIS-1144. Default disable datastream when start a MiniRaftCluster
runzhiwang opened a new pull request #266:
URL: https://github.com/apache/incubator-ratis/pull/266
## What changes were proposed in this pull request?
Default disable datastream when start a MiniRaftCluster, so that the other test no need to start data stream server, to make the CI run faster.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1144
## How was this patch tested?
no need to add new ut.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on a change in pull request #266: RATIS-1144. Default disable datastream when start a MiniRaftCluster
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #266:
URL: https://github.com/apache/incubator-ratis/pull/266#discussion_r520958645
##########
File path: ratis-test/src/test/java/org/apache/ratis/datastream/TestDataStreamNetty.java
##########
@@ -96,6 +96,7 @@ private void testCloseStream(int leaderIndex, int numServers) throws Exception {
RaftPeerId peerId = RaftPeerId.valueOf("s" + i);
RaftProperties properties = new RaftProperties();
NettyConfigKeys.DataStream.setPort(properties, NetUtils.createLocalServerAddress().getPort());
+ RaftConfigKeys.DataStream.setType(properties, SupportedDataStreamType.NETTY);
Review comment:
O I see. thanks for clarification
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on a change in pull request #266: RATIS-1144. Default disable datastream when start a MiniRaftCluster
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #266:
URL: https://github.com/apache/incubator-ratis/pull/266#discussion_r520770461
##########
File path: ratis-test/src/test/java/org/apache/ratis/datastream/TestDataStreamNetty.java
##########
@@ -96,6 +96,7 @@ private void testCloseStream(int leaderIndex, int numServers) throws Exception {
RaftPeerId peerId = RaftPeerId.valueOf("s" + i);
RaftProperties properties = new RaftProperties();
NettyConfigKeys.DataStream.setPort(properties, NetUtils.createLocalServerAddress().getPort());
+ RaftConfigKeys.DataStream.setType(properties, SupportedDataStreamType.NETTY);
Review comment:
hmmm I see `RaftProperties properties = new RaftProperties();` is not using the existing `properties`.
I will take a look and maybe fix this in my branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on a change in pull request #266: RATIS-1144. Default disable datastream when start a MiniRaftCluster
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on a change in pull request #266:
URL: https://github.com/apache/incubator-ratis/pull/266#discussion_r520945968
##########
File path: ratis-test/src/test/java/org/apache/ratis/datastream/TestDataStreamNetty.java
##########
@@ -96,6 +96,7 @@ private void testCloseStream(int leaderIndex, int numServers) throws Exception {
RaftPeerId peerId = RaftPeerId.valueOf("s" + i);
RaftProperties properties = new RaftProperties();
NettyConfigKeys.DataStream.setPort(properties, NetUtils.createLocalServerAddress().getPort());
+ RaftConfigKeys.DataStream.setType(properties, SupportedDataStreamType.NETTY);
Review comment:
@amaliujia It's a mock RaftServer, will not use properties set at line 61.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on a change in pull request #266: RATIS-1144. Default disable datastream when start a MiniRaftCluster
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #266:
URL: https://github.com/apache/incubator-ratis/pull/266#discussion_r520769882
##########
File path: ratis-test/src/test/java/org/apache/ratis/datastream/TestDataStreamNetty.java
##########
@@ -96,6 +96,7 @@ private void testCloseStream(int leaderIndex, int numServers) throws Exception {
RaftPeerId peerId = RaftPeerId.valueOf("s" + i);
RaftProperties properties = new RaftProperties();
NettyConfigKeys.DataStream.setPort(properties, NetUtils.createLocalServerAddress().getPort());
+ RaftConfigKeys.DataStream.setType(properties, SupportedDataStreamType.NETTY);
Review comment:
This line is redundant. If you check line 61 this config is already be set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on pull request #266: RATIS-1144. Default disable datastream when start a MiniRaftCluster
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #266:
URL: https://github.com/apache/incubator-ratis/pull/266#issuecomment-724859596
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo merged pull request #266: RATIS-1144. Default disable datastream when start a MiniRaftCluster
Posted by GitBox <gi...@apache.org>.
szetszwo merged pull request #266:
URL: https://github.com/apache/incubator-ratis/pull/266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org