[GitHub] [incubator-mesatee] mssun commented on a change in pull request #69: Update mesapy to fix FNS/MesaPy FFI issues

[GitBox <gi...@apache.org>]

mssun commented on a change in pull request #69: Update mesapy to fix FNS/MesaPy FFI issues
URL: https://github.com/apache/incubator-mesatee/pull/69#discussion_r349291359
 
 

 ##########
 File path: mesatee_services/fns/sgx_trusted_lib/src/global.rs
 ##########
 @@ -132,10 +137,10 @@ extern "C" fn c_save_file_for_all_participants(
                 out_file_id[..file_id_len].copy_from_slice(file_id.as_bytes());
                 file_id_len as c_int
             } else {
-                out_file_id_buf_size as c_int - file_id_len as c_int
+                FFI_BUFFER_NOT_ENOUGH_ERROR
 
 Review comment:
   We don't know the `file_id_len` before calling `save_file_for_all_participants`. Right now, the max length of  is 36 chars, so we are okay now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mesatee.apache.org
For additional commands, e-mail: dev-help@mesatee.apache.org