You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/27 23:59:41 UTC
[GitHub] codecov-io commented on issue #5745: Update annotation model to
have JSON Metadata field
codecov-io commented on issue #5745: Update annotation model to have JSON Metadata field
URL: https://github.com/apache/incubator-superset/pull/5745#issuecomment-416406738
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5745?src=pr&el=h1) Report
> Merging [#5745](https://codecov.io/gh/apache/incubator-superset/pull/5745?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8d01c84c543a0905e55e9c4e4464249d1c382553?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5745?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5745 +/- ##
==========================================
- Coverage 63.45% 62.99% -0.46%
==========================================
Files 362 363 +1
Lines 22978 23577 +599
Branches 2554 2643 +89
==========================================
+ Hits 14580 14852 +272
- Misses 8383 8710 +327
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5745?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/5745/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `93.1% <100%> (+0.24%)` | :arrow_up: |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/5745/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `76.08% <100%> (+0.53%)` | :arrow_up: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5745/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `41.26% <0%> (-5.01%)` | :arrow_down: |
| [...et/assets/src/visualizations/deckgl/layers/arc.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5745/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL2FyYy5qc3g=) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/sunburst.js](https://codecov.io/gh/apache/incubator-superset/pull/5745/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9zdW5idXJzdC5qcw==) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/BigNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5745/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9CaWdOdW1iZXIuanN4) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/horizon.js](https://codecov.io/gh/apache/incubator-superset/pull/5745/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9ob3Jpem9uLmpz) | `0% <0%> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5745/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `91.82% <0%> (+0.32%)` | :arrow_up: |
| [...sualizations/deckgl/CategoricalDeckGLContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5745/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvQ2F0ZWdvcmljYWxEZWNrR0xDb250YWluZXIuanN4) | `1.09% <0%> (+1.09%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5745/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `84.05% <0%> (+1.49%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5745?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5745?src=pr&el=footer). Last update [8d01c84...578b62d](https://codecov.io/gh/apache/incubator-superset/pull/5745?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org